Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Mode: traffic segregation #1695

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

francescodanzi
Copy link
Contributor

@francescodanzi francescodanzi commented Mar 1, 2023

Description

This PR introduce a new connectivity security mode, named Intra-cluster traffic segregation and documented in the PR #2060

How Has This Been Tested?

  • Locally with KinD

@adamjensenbot
Copy link
Collaborator

Hi @francescodanzi. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli marked this pull request as draft March 1, 2023 09:07
@aleoli
Copy link
Member

aleoli commented Mar 8, 2023

/build

@francescodanzi francescodanzi force-pushed the fda/traffic-control branch 4 times, most recently from ed31b04 to 54dcf32 Compare September 21, 2023 15:58
@francescodanzi francescodanzi marked this pull request as ready for review September 21, 2023 16:02
@cheina97 cheina97 changed the title Fda/traffic control Security Mode: traffic segregation Sep 21, 2023
@cheina97 cheina97 self-requested a review September 21, 2023 16:07
@Sharathmk99
Copy link
Contributor

If you are ok, can you please help us to understand what does it mean by network traffic segregation means? Thanks

build/liqonet/Dockerfile Outdated Show resolved Hide resolved
cmd/liqonet/gateway-operator.go Outdated Show resolved Hide resolved
cmd/liqonet/gateway-operator.go Outdated Show resolved Hide resolved
cmd/liqonet/gateway-operator.go Outdated Show resolved Hide resolved
cmd/liqonet/gateway-operator.go Outdated Show resolved Hide resolved
pkg/liqonet/ipset/ipset.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/utils/random.go Outdated Show resolved Hide resolved
@cheina97
Copy link
Member

/test

@cheina97
Copy link
Member

/build

pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
@francescodanzi
Copy link
Contributor Author

/test

pkg/utils/mapper/mapper.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Outdated Show resolved Hide resolved
pkg/liqonet/iptables/iptables.go Show resolved Hide resolved
@francescodanzi
Copy link
Contributor Author

/test

1 similar comment
@francescodanzi
Copy link
Contributor Author

/test

@francescodanzi francescodanzi force-pushed the fda/traffic-control branch 3 times, most recently from 179625c to 02ee48b Compare October 4, 2023 13:25
@francescodanzi
Copy link
Contributor Author

/test

1 similar comment
@aleoli
Copy link
Member

aleoli commented Oct 4, 2023

/test

Copy link
Member

@aleoli aleoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description to the pr?

@cheina97
Copy link
Member

/rebase test=true

@francescodanzi
Copy link
Contributor Author

@Sharathmk99 sorry for the wait in response, you can find documentation here: #2060

@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 13, 2023
@adamjensenbot adamjensenbot merged commit 9dd9602 into liqotech:master Oct 13, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants