Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added possibility to switch to iptables nf_tables #1970

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Added possibility to switch to iptables nf_tables #1970

merged 1 commit into from
Aug 25, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Aug 24, 2023 •
edited
Loading

Description

This PR adds the possibility of forcing the usage of iptables legacy/nf_tables using the env variable IPTABLES_MODE which accept 2 values:

  • legacy
  • nf_tables

If not set the used iptables mode will be the system default (legacy in case of alpine)

This PR uses a fork of the official go-iptables package while waiting for the PR
coreos/go-iptables#110 to be merged.

How Has This Been Tested?

  • Locally on KinD

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/nf_tables branch 2 times, most recently from 65970b3 to fd86cc0 Compare August 24, 2023 15:12
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 24, 2023
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 requested review from aleoli and fra98 August 24, 2023 15:26
@cheina97 cheina97 added the kind/feature New feature or request label Aug 24, 2023
aleoli
aleoli approved these changes Aug 25, 2023
View reviewed changes
deployments/liqo/values.yaml Show resolved Hide resolved
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the frc/nf_tables branch 2 times, most recently from 35f44ab to 818b253 Compare August 25, 2023 10:14
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 25, 2023
@adamjensenbot adamjensenbot merged commit e21d5ce into liqotech:master Aug 25, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 25, 2023
@cheina97 cheina97 deleted the frc/nf_tables branch November 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli