Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug endpoints not reflected #2032

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix bug endpoints not reflected #2032

merged 1 commit into from
Sep 20, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 19, 2023 •
edited
Loading

Description

This PR fixes a bug that prevented endpoints from being reflected when the Liqo node was disabled in the VirtualNode spec.

How Has This Been Tested?

  • locally
  • e2e tests
  • unit tests

@fra98 fra98 added the kind/bug label Sep 19, 2023
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Sep 19, 2023

/test

@fra98 fra98 changed the title Fix bug endpoints reflected not reflected Fix bug endpoints not reflected Sep 19, 2023
@fra98 fra98 force-pushed the frt/refl-endpoint-fix branch 2 times, most recently from 7133f80 to b06f353 Compare September 20, 2023 09:37
@fra98
Copy link
Member Author

fra98 commented Sep 20, 2023

/test

@fra98 fra98 requested review from cheina97 and aleoli September 20, 2023 09:38
@fra98 fra98 force-pushed the frt/refl-endpoint-fix branch from b06f353 to 6f49f55 Compare September 20, 2023 13:00
@fra98
Copy link
Member Author

fra98 commented Sep 20, 2023

/test

@fra98
Copy link
Member Author

fra98 commented Sep 20, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 20, 2023
@adamjensenbot adamjensenbot merged commit 760021d into liqotech:master Sep 20, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 20, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli