Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fake IPAMClient #2042

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 22, 2023

Description

This PR updates the fake IPAMClient with the new methods.
In addition, it fixes the Uninstall e2e test.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Sep 22, 2023

/test

@cheina97
Copy link
Member

/rebase test=true

@fra98 fra98 force-pushed the frt/ipam-tests-fix branch from abddf36 to 9c79e9f Compare September 22, 2023 15:12
@fra98
Copy link
Member Author

fra98 commented Sep 22, 2023

/test

@fra98 fra98 merged commit bf90f5f into liqotech:network-general Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants