-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpointslices reflection fix #2043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
aleoli
approved these changes
Sep 25, 2023
fra98
force-pushed
the
frt/eps-reflection-fix
branch
2 times, most recently
from
September 25, 2023 09:40
daf93c5
to
786edf0
Compare
fra98
force-pushed
the
frt/eps-reflection-fix
branch
from
September 25, 2023 10:00
786edf0
to
6d10a0e
Compare
/test |
fra98
force-pushed
the
frt/eps-reflection-fix
branch
from
September 25, 2023 10:42
6d10a0e
to
53c0599
Compare
/test |
fra98
force-pushed
the
frt/eps-reflection-fix
branch
from
September 25, 2023 13:46
53c0599
to
58ff1b9
Compare
/test |
/merge |
adamjensenbot
added
the
merge-requested
Request bot merging (automatically managed)
label
Sep 25, 2023
adamjensenbot
removed
the
merge-requested
Request bot merging (automatically managed)
label
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2036
This PR fixes a bug where endpointslices were reflected even if the associated service is marked with skip annotation.
The new logic to decide whether an endpointslice must be reflected or not is the following:
liqo.io/allow-reflection
annotation, do not reflect usingliqo.io/skip-reflection
)