Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpointslices reflection fix #2043

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 22, 2023

Description

Fixes #2036
This PR fixes a bug where endpointslices were reflected even if the associated service is marked with skip annotation.
The new logic to decide whether an endpointslice must be reflected or not is the following:

  • the endpointslices reflector will inherit the reflection type from the services reflector
  • an endpointslice is (not) reflected if the associated service is (not) reflected
  • you can bypass the above behavior if you explicitly annotate the endpointslice itself (i.e., reflect the endpointslice using liqo.io/allow-reflection annotation, do not reflect using liqo.io/skip-reflection)

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

cmd/virtual-kubelet/root/root.go Outdated Show resolved Hide resolved
pkg/virtualKubelet/reflection/exposition/endpointslice.go Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/eps-reflection-fix branch 2 times, most recently from daf93c5 to 786edf0 Compare September 25, 2023 09:40
@fra98 fra98 requested a review from aleoli September 25, 2023 09:41
@fra98 fra98 force-pushed the frt/eps-reflection-fix branch from 786edf0 to 6d10a0e Compare September 25, 2023 10:00
@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/test

@fra98 fra98 force-pushed the frt/eps-reflection-fix branch from 6d10a0e to 53c0599 Compare September 25, 2023 10:42
@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/test

@fra98 fra98 force-pushed the frt/eps-reflection-fix branch from 53c0599 to 58ff1b9 Compare September 25, 2023 13:46
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 25, 2023
@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/test

@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 25, 2023
@adamjensenbot adamjensenbot merged commit 4edf128 into liqotech:master Sep 25, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EndpointSlices Reflection should happen for services I annotated to offload from local cluster
3 participants