Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqoctl add network Configuration commands #2059

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Liqoctl add network Configuration commands #2059

merged 1 commit into from
Oct 11, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Oct 3, 2023

Description

This pr adds the commands to liqoctl in order to manage network configurations

How Has This Been Tested?

  • locally

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch 2 times, most recently from 0b922b9 to 129555e Compare October 3, 2023 14:12
@aleoli
Copy link
Member Author

aleoli commented Oct 3, 2023

/build

@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch from aa7aadf to efe8250 Compare October 4, 2023 09:22
@aleoli
Copy link
Member Author

aleoli commented Oct 4, 2023

/build

@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch from 66fb44f to ae4ff4f Compare October 4, 2023 12:45
@aleoli
Copy link
Member Author

aleoli commented Oct 4, 2023

/build

@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch from ae4ff4f to 3598acc Compare October 4, 2023 13:01
@aleoli aleoli marked this pull request as ready for review October 4, 2023 13:13
@aleoli aleoli requested review from cheina97 and fra98 October 4, 2023 13:13
@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch 3 times, most recently from e8365ea to d4eee6e Compare October 6, 2023 08:43
fra98
fra98 reviewed Oct 6, 2023
View reviewed changes
pkg/liqoctl/rest/configuration/generate.go Outdated Show resolved Hide resolved
pkg/liqoctl/rest/configuration/create.go Outdated Show resolved Hide resolved
pkg/liqoctl/rest/configuration/create.go Outdated Show resolved Hide resolved
@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch from d63804d to f002e47 Compare October 9, 2023 14:35
@cheina97
Copy link
Member

cheina97 commented Oct 10, 2023 •
edited
Loading

LGTM

@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch from f002e47 to de50356 Compare October 10, 2023 14:39
@aleoli aleoli force-pushed the aol/liqoctl-network-configuration branch from de50356 to d60d0d5 Compare October 11, 2023 14:22
@aleoli
Copy link
Member Author

aleoli commented Oct 11, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 11, 2023
@adamjensenbot adamjensenbot merged commit d841dd4 into liqotech:network-external Oct 11, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleoli @adamjensenbot @cheina97 @fra98