Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Network: connection controller #2074

Merged
merged 1 commit into from
Oct 25, 2023
Merged

External Network: connection controller #2074

merged 1 commit into from
Oct 25, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Oct 10, 2023 •
edited
Loading

Description

This PR introduces a container that implements the generic features, like connection check and firewall.

This PR focuses only on Connection resources and connection checking, migrating the ConnChecker already used in the current network.

@cheina97 cheina97 marked this pull request as draft October 10, 2023 15:36
@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 changed the title Frc/connectioncontroller External Network: connection controller Oct 10, 2023
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch 3 times, most recently from 0a502f6 to 584dab3 Compare October 11, 2023 08:16
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch 21 times, most recently from 4599789 to 99d5a35 Compare October 16, 2023 16:35
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch from 35d0687 to dcbc761 Compare October 19, 2023 06:52
@cheina97 cheina97 marked this pull request as ready for review October 19, 2023 06:52
@cheina97 cheina97 requested review from aleoli and fra98 October 19, 2023 06:52
@cheina97 cheina97 mentioned this pull request Oct 19, 2023
Merged
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch 9 times, most recently from 76e36f3 to a4d4c4c Compare October 23, 2023 12:32
fra98
fra98 approved these changes Oct 23, 2023
View reviewed changes
pkg/gateway/connection/connections-controller.go Outdated Show resolved Hide resolved
pkg/gateway/tunnel/wireguard/publickeys-controller.go Outdated Show resolved Hide resolved
pkg/gateway/connection/connections-controller.go Outdated Show resolved Hide resolved
aleoli
aleoli approved these changes Oct 23, 2023
View reviewed changes
pkg/gateway/connection/connections-controller.go Outdated Show resolved Hide resolved
pkg/gateway/tunnel/wireguard/dns.go Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch 2 times, most recently from 947247d to aad6dfd Compare October 24, 2023 09:46
aleoli
aleoli approved these changes Oct 24, 2023
View reviewed changes
pkg/gateway/connection/conncheck/conncheck.go Outdated Show resolved Hide resolved
pkg/gateway/connection/conncheck/conncheck.go Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch from 225d39e to 5938dee Compare October 24, 2023 20:44
@cheina97 cheina97 force-pushed the frc/connectioncontroller branch from 5938dee to 624997c Compare October 24, 2023 20:44
@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 25, 2023
@adamjensenbot adamjensenbot merged commit cc2e4b4 into liqotech:network-external Oct 25, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 25, 2023
@cheina97 cheina97 deleted the frc/connectioncontroller branch November 2, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheina97 @adamjensenbot @aleoli @fra98