Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Mode: E2E tests #2084

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Security Mode: E2E tests #2084

merged 1 commit into from
Oct 24, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Oct 13, 2023 •
edited by aleoli
Loading

Description

This PR adds E2E tests for security modes.

How Has This Been Tested?

  • Liqo CI

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

aleoli
aleoli approved these changes Oct 16, 2023
View reviewed changes
test/e2e/pipeline/installer/liqoctl/setup.sh Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the frc/securitymodetests branch from 0db6d42 to 7efdb18 Compare October 16, 2023 17:01
@aleoli aleoli force-pushed the frc/securitymodetests branch from 7efdb18 to 084e8f6 Compare October 23, 2023 10:05
@aleoli
Copy link
Member

aleoli commented Oct 23, 2023

/test

@aleoli
Copy link
Member

aleoli commented Oct 23, 2023

/test

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 23, 2023
@aleoli
Copy link
Member

aleoli commented Oct 23, 2023

/test

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 24, 2023
@aleoli
Copy link
Member

aleoli commented Oct 24, 2023

/test

@aleoli aleoli force-pushed the frc/securitymodetests branch from 579df29 to 92317ee Compare October 24, 2023 09:56
@cheina97 @aleoli
Security Mode: E2E tests
7de6fd2 
co-authored-by: Alessandro Olivero <[email protected]>
@aleoli aleoli force-pushed the frc/securitymodetests branch from 92317ee to 7de6fd2 Compare October 24, 2023 09:59
@aleoli
Copy link
Member

aleoli commented Oct 24, 2023

/test

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 24, 2023
@adamjensenbot adamjensenbot merged commit 4f4b45d into liqotech:master Oct 24, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 24, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
@cheina97 cheina97 deleted the frc/securitymodetests branch November 2, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli