Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified the use of custom installation options #2086

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Clarified the use of custom installation options #2086

merged 1 commit into from
Oct 17, 2023

Conversation

frisso
Copy link
Member

@frisso frisso commented Oct 15, 2023

No description provided.

@adamjensenbot
Copy link
Collaborator

Hi @frisso. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
@frisso frisso requested a review from cheina97 October 15, 2023 06:54
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
frisso
frisso commented Oct 15, 2023
View reviewed changes
docs/installation/install.md Outdated Show resolved Hide resolved
cheina97
cheina97 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@cheina97 cheina97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cheina97
Copy link
Member

/rebase test=true

@cheina97
Copy link
Member

/test

@cheina97
Copy link
Member

/rebase test=true

@cheina97 cheina97 force-pushed the frs/install-parameters-doc branch from fbd65bb to f14dc41 Compare October 16, 2023 16:33
@cheina97
Copy link
Member

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frs/install-parameters-doc branch from f14dc41 to 6fd9e35 Compare October 17, 2023 15:25
@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 17, 2023
@adamjensenbot adamjensenbot merged commit 3ad8a76 into master Oct 17, 2023
8 checks passed
@adamjensenbot adamjensenbot deleted the frs/install-parameters-doc branch October 17, 2023 15:48
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 17, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frisso @adamjensenbot @cheina97