Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecretRef to top-level resources #2087

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Oct 16, 2023

Description

This pr adds the secret ref to the top-level external network resources, in order to make easier for external tools to understand when the gateway is set up

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Oct 16, 2023

/build

@aleoli aleoli marked this pull request as ready for review October 16, 2023 10:14
@aleoli aleoli requested review from cheina97 and fra98 October 16, 2023 10:15
@aleoli aleoli force-pushed the aol/en-add-secret branch from a912927 to 4637a75 Compare October 16, 2023 10:22
@aleoli aleoli force-pushed the aol/en-add-secret branch from 4637a75 to 3a2e167 Compare October 16, 2023 12:36
@aleoli
Copy link
Member Author

aleoli commented Oct 16, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 16, 2023
@adamjensenbot adamjensenbot merged commit 6861dad into liqotech:network-external Oct 16, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants