Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Network: support allocating static LoadBalancerIP and NodePort #2105

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 20, 2023

Description

This PR adds the support to allocate static LoadBalancerIP and NodePort.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from cf26f8f to aec0b17 Compare October 25, 2023 09:15
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from aec0b17 to 1aa1414 Compare October 26, 2023 15:51
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from 1aa1414 to 7ef4440 Compare October 27, 2023 13:37
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch 2 times, most recently from 6caa022 to 53e35d2 Compare November 2, 2023 15:37
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from ff38b4a to 1ce5846 Compare November 9, 2023 11:10
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from 1ce5846 to c3fd686 Compare November 9, 2023 16:43
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Nov 9, 2023
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from c3fd686 to a1f12db Compare November 9, 2023 17:25
@fra98 fra98 marked this pull request as ready for review November 9, 2023 17:25
cmd/liqoctl/cmd/network.go Outdated Show resolved Hide resolved
pkg/liqoctl/network/cluster.go Outdated Show resolved Hide resolved
pkg/liqoctl/rest/gatewayserver/create.go Outdated Show resolved Hide resolved
@fra98 fra98 requested a review from aleoli November 13, 2023 11:58
@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from a1f12db to 5945e70 Compare November 13, 2023 13:50
@cheina97
Copy link
Member

/rebase test=true

@fra98 fra98 force-pushed the frt/allocate-static-np-lb branch from 571e1b9 to ff3c503 Compare November 14, 2023 15:37
@fra98 fra98 merged commit 1d42ff8 into liqotech:network-external Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants