Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Network: liqoctl network reset and disconnect #2112

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 25, 2023

Description

This PR implements the liqoctl network reset and disconnect commands, and the REST Delete method for Configurations, PublicKeys, GatewayServers, GatewayClients

In addition:

  • prevent running liqoctl network connect without issuing liqoctl network init first

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 changed the title External Networl: liqoctl network reset and disconnect External Network: liqoctl network reset and disconnect Oct 25, 2023
@fra98 fra98 force-pushed the frt/liqoctl-network-delete branch from 6481c5a to b2f421f Compare October 26, 2023 15:44
@fra98 fra98 force-pushed the frt/liqoctl-network-delete branch 2 times, most recently from 633b366 to fd77f16 Compare October 27, 2023 13:32
@fra98 fra98 marked this pull request as ready for review October 27, 2023 13:32
@fra98 fra98 force-pushed the frt/liqoctl-network-delete branch from 0cc440e to 6a915ab Compare October 30, 2023 11:40
@fra98 fra98 requested a review from aleoli October 30, 2023 11:40
@fra98 fra98 force-pushed the frt/liqoctl-network-delete branch 2 times, most recently from 8d06487 to deff9b8 Compare November 2, 2023 15:32
@fra98 fra98 force-pushed the frt/liqoctl-network-delete branch from deff9b8 to ed508e3 Compare November 9, 2023 11:04
pkg/liqoctl/network/cluster.go Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/liqoctl-network-delete branch from ed508e3 to d4ddede Compare November 9, 2023 16:23
@fra98 fra98 merged commit 16067af into liqotech:network-external Nov 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants