Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix HA replicas checks #2804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: fix HA replicas checks #2804

wants to merge 1 commit into from
+108 −29

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 5, 2024 •
edited
Loading

Description

This PR modifies tests for HA components. In particular:

  • lowered the replicas from 3 to 2
  • checker for ready pods now dynamically checks the expected number of pods depending on how HA was configured
  • fixed Eventually() statements in network_test.go
  • added test to check if exactly one gateway pod is Active
  • fixed a bug in the SmartMergeLabels and SmartMergeAnnotations functions

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 changed the title test: fix HA replicas tests test: fix HA replicas checks Nov 5, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 5, 2024

/test

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 5, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 5, 2024

/test

@fra98 fra98 added the kind/cleanup Refactoring code label Nov 5, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 5, 2024

/test

@fra98 fra98 added kind/bug Something isn't working and removed kind/cleanup Refactoring code labels Nov 8, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 8, 2024

/test

2 similar comments
@fra98
Copy link
Member Author

fra98 commented Nov 8, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Nov 8, 2024

/test

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 13, 2024
@fra98 fra98 marked this pull request as draft November 13, 2024 09:57
@fra98
Copy link
Member Author

fra98 commented Nov 13, 2024

/test

1 similar comment
@fra98
Copy link
Member Author

fra98 commented Nov 13, 2024

/test

@fra98 fra98 force-pushed the frt/ha-replicas-test branch 2 times, most recently from 80a91bf to 3a316e3 Compare November 14, 2024 14:57
@fra98 fra98 marked this pull request as ready for review November 14, 2024 15:07
@fra98
Copy link
Member Author

fra98 commented Nov 14, 2024

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

@claudiolor claudiolor Awaiting requested review from claudiolor

Assignees
No one assigned
Labels
kind/bug Something isn't working size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli