Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wggateway controllers pod watch #2815

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cheina97
Copy link
Member

Description

This PR fixes a bug about wireguard gateway server and client controllers. With the new leader election mechanism introduced to support HA on gateways these controllers need to be triggered when gateway pod labels change.

@cheina97 cheina97 added the kind/bug Something isn't working label Nov 14, 2024
@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

test/e2e/cruise/network/network_test.go Outdated Show resolved Hide resolved
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 closed this Nov 14, 2024
@cheina97 cheina97 reopened this Nov 14, 2024
@cheina97
Copy link
Member Author

-merge

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 14, 2024
@adamjensenbot adamjensenbot merged commit b242938 into liqotech:master Nov 14, 2024
21 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 14, 2024
@cheina97 cheina97 deleted the frc/testnet branch November 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants