-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-18282 DevOps :: Docker Issue in create-release.yml #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the workflow file to use the latest version of the tool. Also, commented out the steps related to updating the official Docker repository as they are not needed at the moment.
…or improved security and integrity
…to optimize performance and readability 🔧 (create-release.yml): Comment out unnecessary actions/checkout and actions/setup-java steps to improve workflow readability and reduce unnecessary steps. 📝 (workflow.yml): update script to extract major.minor version and print full version for debugging purposes
…'update-dockerfiles' job for the liquibase version to ensure consistency and accuracy in the Docker image tags and versioning.
…ersion from update-dockerfiles job output for consistency and accuracy
…ames for consistency and improve readability 🔧 (create-release.yml): Update Dockerfile to support different architectures for Docker image building and pushing 🔧 (create-release.yml): update workflow to use uppercase letters for environment variables for consistency and readability 🔧 (create-release.yml): update workflow to use correct indentation for job steps for better readability and maintainability
sayaliM0412
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚒
jnewton03
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ (create-release.yml): Update LPM_VERSION from "0.2.6" to "0.2.7" in the workflow file to use the latest version of the tool. Also, commented out the steps related to updating the official Docker repository as they are not needed at the moment.