Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAT-18261] feat: snapshotting of extended view properties #191

Merged
merged 14 commits into from
Oct 11, 2024

Conversation

filipelautert
Copy link
Contributor

@filipelautert filipelautert commented Oct 2, 2024

Class ViewSnapshotGeneratorDatabricks.java had a lot of not used code so it was heavily refactored.

@filipelautert filipelautert self-assigned this Oct 2, 2024
@filipelautert filipelautert marked this pull request as ready for review October 3, 2024 20:21
@filipelautert filipelautert changed the title feat: adding snapshoting of extended view properties (in development) [DAT-18261] feat: snapshotting of extended view properties Oct 3, 2024
Copy link
Contributor

@SvampX SvampX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit!

Copy link
Contributor

@KushnirykOleh KushnirykOleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!

@rberezen
Copy link

rberezen commented Oct 9, 2024

@filipelautert @KushnirykOleh @SvampX hey team, have a general question
should we add tests into this pr? if yes, who usually do this: dev or qa? Is it enough to test manualy from my side?

@KushnirykOleh
Copy link
Contributor

good point @rberezen. let me update expectedSnapshot to include tblProperties

dependabot bot and others added 10 commits October 10, 2024 15:45
Bumps `junit.version` from 5.11.1 to 5.11.2.

Updates `org.junit.jupiter:junit-jupiter-api` from 5.11.1 to 5.11.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.11.1...r5.11.2)

Updates `org.junit.vintage:junit-vintage-engine` from 5.11.1 to 5.11.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.11.1...r5.11.2)

Updates `org.junit.jupiter:junit-jupiter-engine` from 5.11.1 to 5.11.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.11.1...r5.11.2)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.junit.vintage:junit-vintage-engine
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.junit.jupiter:junit-jupiter-engine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps `junit-platform.version` from 1.11.1 to 1.11.2.

Updates `org.junit.platform:junit-platform-suite` from 1.11.1 to 1.11.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](https://github.com/junit-team/junit5/commits)

Updates `org.junit.platform:junit-platform-launcher` from 1.11.1 to 1.11.2
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](https://github.com/junit-team/junit5/commits)

---
updated-dependencies:
- dependency-name: org.junit.platform:junit-platform-suite
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.junit.platform:junit-platform-launcher
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ed to PRIORITY_DATABASE, removed unnecesary dependency on jdbc jar.
Copy link

@filipelautert
Copy link
Contributor Author

good point @rberezen. let me update expectedSnapshot to include tblProperties

whops, seems I forgot to add this. Thanks for jumping in @KushnirykOleh !

@KushnirykOleh KushnirykOleh merged commit 987f892 into main Oct 11, 2024
17 checks passed
@KushnirykOleh KushnirykOleh deleted the DAT-18261 branch October 11, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants