Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAT-18790] added defaultValue snapshotting #192

Merged
merged 10 commits into from
Nov 18, 2024
Merged

[DAT-18790] added defaultValue snapshotting #192

merged 10 commits into from
Nov 18, 2024

Conversation

KushnirykOleh
Copy link
Contributor

No description provided.

@liquibase liquibase deleted a comment from sonarqubecloud bot Oct 24, 2024
@SvampX SvampX marked this pull request as ready for review October 24, 2024 12:41
@SvampX SvampX requested a review from filipelautert as a code owner October 24, 2024 12:41
@SvampX
Copy link
Contributor

SvampX commented Oct 24, 2024

Should work for most cases except:
Default value is calculated by a function with multiple arguments like eventDate DATE DEFAULT coalesce(CAST(CURRENT_TIMESTAMP() AS DATE), CAST('2024.09.09' AS DATE))

DAT-18790: review changes - optimized DB calls from one per column to…
6178f64 
… one per table for column default values. updated test
filipelautert
filipelautert approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

KushnirykOleh
KushnirykOleh commented Oct 28, 2024
View reviewed changes
Copy link
Contributor Author

@KushnirykOleh KushnirykOleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
(I can't approve as i opened PR originally)

@filipelautert filipelautert requested a review from SvampX November 14, 2024 19:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
3 Accepted issues

Measures
0 Security Hotspots
70.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SvampX SvampX merged commit 5da8172 into main Nov 18, 2024
18 checks passed
@SvampX SvampX deleted the DAT-18790 branch November 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@SvampX SvampX Awaiting requested review from SvampX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KushnirykOleh @SvampX @filipelautert @PavloTytarchuk