-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-18792: added cluster by support for snapshot and diff table related change types #199
Conversation
As per described in extracting and cleaning methods possible issues we might try different way to read and store TBLPROPERTIES. Partially it was done on the view side here https://github.com/liquibase/liquibase-databricks/blob/main/src/main/java/liquibase/ext/databricks/snapshot/jvm/ViewSnapshotGeneratorDatabricks.java#L81-L89 |
…characters enumeration to character class.
Are we writing tests for this PR? |
|
…blProperty 'clusteringColumns', extended snapshot check, removed unnecessary user defined property cleanup. Moved sanitizing logic to snapshot generator to avoid spreading of responsibilities.
src/main/java/liquibase/ext/databricks/sqlgenerator/CreateTableGeneratorDatabricks.java
Outdated
Show resolved
Hide resolved
…erties in quotes, createTable changetype namespace as ext.
…on how to enable serializableFieldType as an element against defaulting attribute
Quality Gate passedIssues Measures |
Tested following liquibase commands:
Changelog generates with present CLUSTER BY part with appropriate columns. Tested case with 1 and 2 clustering columns.
Generated changeset example: