Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT-18491: Added verification of user specified schema and catalog inconnection uri #211

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

SvampX
Copy link
Contributor

@SvampX SvampX commented Nov 5, 2024

Tested all 3 cases with non existing catalog and/or non existing schema.

Screenshot 2024-11-06 at 15 57 50

@SvampX SvampX marked this pull request as ready for review November 6, 2024 09:59
@SvampX SvampX requested a review from filipelautert as a code owner November 6, 2024 09:59
Copy link
Contributor

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Mykhailo Savchenko added 4 commits November 6, 2024 14:42
… getConnectionSchemaName instead of manually parsing. Removed ombigious check.
…schema should be present anyway if credentials and path to Database are correct.
Copy link

sonarqubecloud bot commented Nov 6, 2024

@SvampX SvampX merged commit ce73780 into main Nov 11, 2024
17 checks passed
@SvampX SvampX deleted the DAT-18491 branch November 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants