Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support liquibase4.30.0 #69

Closed
wants to merge 3 commits into from

Conversation

momosetkn
Copy link

@momosetkn momosetkn commented Nov 6, 2024

@momosetkn momosetkn changed the title Support liquibase 4.30.0 Support liquibase4.30.0 Nov 6, 2024
@stevesaliman
Copy link
Collaborator

I'm concerned about backwards compatibility with this PR.

The arguments being passed to DatabaseChangelog's include and includeAll methods have changed, but what if the user doesn't want to upgrade to 4.30.0? This would be a breaking change. We'll need a way to detect which version of Liquibase is being used and call the appropriate method for the version. I think older versions of the DSL did something like this. I don't remember if it detected the version, or just whether a specific property was supported.

We also need to make sure that any changes to includeAll work with includeAllSql. It looks like a modification was made to createIncludeAllParams, but the new paramater wasn't added to the includeAllKeys array in the includeAllSql method itself.

@stevesaliman
Copy link
Collaborator

Support for Liquibase 4.31.1 has been added in a separate commit, and will be included with the 4.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants