-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multi-schema support #727
Open
philipp-kleber-avelios
wants to merge
5
commits into
liquibase:main
Choose a base branch
from
philipp-kleber-avelios:multi-schema-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0385016
Implement multi-schema support
philipp-kleber-avelios 5396ef5
Merge branch 'main' into multi-schema-support
MalloD12 ca205e4
Improve constant names in HibernateDatabase
philipp-kleber-avelios 477bc66
Extract schema matching logic to HibernateSnapshotGenerator.
philipp-kleber-avelios 21227fc
Merge branch 'main' into multi-schema-support
MalloD12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
src/test/java/com/example/multischema/auction/AuctionInfo.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
package com.example.multischema.auction; | ||
|
||
import jakarta.persistence.Column; | ||
import jakarta.persistence.Entity; | ||
import jakarta.persistence.Id; | ||
import jakarta.persistence.Table; | ||
|
||
import java.util.Date; | ||
|
||
@Entity | ||
@Table(schema = "PUBLIC") | ||
public class AuctionInfo { | ||
private String id; | ||
private String description; | ||
private Date ends; | ||
private Float maxAmount; | ||
|
||
@Column(length = 1000) | ||
public String getDescription() { | ||
return description; | ||
} | ||
|
||
public Date getEnds() { | ||
return ends; | ||
} | ||
|
||
@Id | ||
public String getId() { | ||
return id; | ||
} | ||
|
||
|
||
public Float getMaxAmount() { | ||
return maxAmount; | ||
} | ||
|
||
public void setId(String id) { | ||
this.id = id; | ||
} | ||
|
||
public void setDescription(String description) { | ||
this.description = description; | ||
} | ||
|
||
public void setEnds(Date ends) { | ||
this.ends = ends; | ||
} | ||
|
||
public void setMaxAmount(Float maxAmount) { | ||
this.maxAmount = maxAmount; | ||
} | ||
|
||
public AuctionInfo(String id, String description, Date ends, Float maxAmount) { | ||
this.id = id; | ||
this.description = description; | ||
this.ends = ends; | ||
this.maxAmount = maxAmount; | ||
} | ||
|
||
} |
86 changes: 86 additions & 0 deletions
86
src/test/java/com/example/multischema/auction/AuctionItem.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
package com.example.multischema.auction; | ||
|
||
import jakarta.persistence.*; | ||
|
||
import java.util.Date; | ||
import java.util.List; | ||
|
||
@Entity | ||
@Table(schema = "PUBLIC") | ||
public class AuctionItem extends Persistent { | ||
private String description; | ||
private String shortDescription; | ||
private List<Bid> bids; | ||
private Bid successfulBid; | ||
private User seller; | ||
private Date ends; | ||
private int condition; | ||
|
||
@OneToMany(mappedBy = "item", cascade = CascadeType.ALL) | ||
public List<Bid> getBids() { | ||
return bids; | ||
} | ||
|
||
@Column(length = 1000) | ||
public String getDescription() { | ||
return description; | ||
} | ||
|
||
@ManyToOne | ||
public User getSeller() { | ||
return seller; | ||
} | ||
|
||
@ManyToOne | ||
public Bid getSuccessfulBid() { | ||
return successfulBid; | ||
} | ||
|
||
public void setBids(List<Bid> bids) { | ||
this.bids = bids; | ||
} | ||
|
||
public void setDescription(String string) { | ||
description = string; | ||
} | ||
|
||
public void setSeller(User user) { | ||
seller = user; | ||
} | ||
|
||
public void setSuccessfulBid(Bid bid) { | ||
successfulBid = bid; | ||
} | ||
|
||
public Date getEnds() { | ||
return ends; | ||
} | ||
|
||
public void setEnds(Date date) { | ||
ends = date; | ||
} | ||
|
||
public int getCondition() { | ||
return condition; | ||
} | ||
|
||
public void setCondition(int i) { | ||
condition = i; | ||
} | ||
|
||
public String toString() { | ||
return shortDescription + " (" + description + ": " + condition | ||
+ "/10)"; | ||
} | ||
|
||
@Column(length = 200) | ||
public String getShortDescription() { | ||
return shortDescription; | ||
} | ||
|
||
public void setShortDescription(String shortDescription) { | ||
this.shortDescription = shortDescription; | ||
} | ||
|
||
|
||
} |
34 changes: 34 additions & 0 deletions
34
src/test/java/com/example/multischema/auction/AuditedItem.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package com.example.multischema.auction; | ||
|
||
import jakarta.persistence.*; | ||
import org.hibernate.envers.Audited; | ||
|
||
@Audited | ||
@Entity | ||
@Table(schema = "PUBLIC") | ||
public class AuditedItem { | ||
|
||
@Id | ||
@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "AUDITED_ITEM_SEQ") | ||
@SequenceGenerator(name = "AUDITED_ITEM_SEQ", sequenceName = "AUDITED_ITEM_SEQ") | ||
private long id; | ||
@Column(unique = true) | ||
private String name; | ||
|
||
public long getId() { | ||
return id; | ||
} | ||
|
||
public void setId(long id) { | ||
this.id = id; | ||
} | ||
|
||
public String getName() { | ||
return name; | ||
} | ||
|
||
public void setName(String name) { | ||
this.name = name; | ||
} | ||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipp-kleber-avelios Why
getConnectionCatalogName()
andgetConnectionSchemaName()
are being locked here to constants?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
getConnectionCatalogName()
, the behavior is the same as before just without one less indirection (it used to callgetDefaultCatalogName()
internally).For
getConnectionSchemaName()
, the behavior is slightly different from before:It used to call
getDefaultSchemaName()
internally, but we can't do this anymore: The newgetDefaultSchemaName()
implementation callssuper.getDefaultSchemaName()
and this then callsgetConnectionSchemaName()
, so we'd have a call-cycle.