support multiple URLs in connection string #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/java/liquibase/ext/opensearch/MultipleOpenSearchNodesLiquibaseIT.java
Fixed
Show fixed
Hide fixed
rursprung
force-pushed
the
support-multiple-urls
branch
from
275f02d to
c3fb7c9
Compare
reta
reviewed
Nov 22, 2024
src/main/java/liquibase/ext/opensearch/database/OpenSearchLiquibaseDatabase.java
Outdated
Show resolved
Hide resolved
rursprung
force-pushed
the
support-multiple-urls
branch
from
c3fb7c9 to
f5e0da6
Compare
the underlying OpenSearch library supports multiple URLs, thus we should do the same here as well. since Liquibase has no concept of this on its own we have to use a workaround and use a character to concatenate multiple URLs together. `,` is being used for this as it's normally not part of URLs and it's already used in the OpenSearch client for this purpose. the `opensearch:` prefix should not be repeated. i.e. a URL with multiple addresses should be defined like this: ``` opensearch:http://localhost:9200,http://localhost:9201,http://localhost:9203 ``` the login information is the same for all, since they must form a cluster.
rursprung
force-pushed
the
support-multiple-urls
branch
from
f5e0da6 to
8adb9b9
Compare
reta
approved these changes
Nov 22, 2024
|
filipelautert
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commit messages for further details.