Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT-16000



 liquibase-redshift using Liquibase Parent POM #174

Merged
merged 21 commits into from
Oct 16, 2023

Conversation

jandroav
Copy link
Contributor

@github-actions
Copy link
Contributor

Label error: This PR is being prevented from merging because you have not added one of the labels: breakingChanges, newContributors, notableChanges, sdou, skipReleaseNotes, TypeBug, TypeEnhancement, TypeTest. You'll need to add it before this PR can be merged.

jandroav added 16 commits October 13, 2023 12:17
…s of actions/checkout and actions/setup-java

feat(test.yml): add support for setting the latest liquibase version as a property in the Maven project
feat(test.yml): add step to get the artifact ID of the Maven project
refactor(test.yml): remove unused build cache step
…OT to 0.2.5 for desired version

chore(pom.xml): remove unnecessary whitespace
… for development purposes

chore(pom.xml): update groovy-all.version to 2.4.21 for compatibility with other dependencies
chore(pom.xml): update junit version to 4.13.2 for testing purposes
…OT to 0.2.5 for stability and desired functionality
…orts

The jacoco-maven-plugin is added to the project's pom.xml file. This plugin is used to generate code coverage reports using JaCoCo. The plugin is configured to include the jacoco.exec file generated during the test execution. This will allow us to track the code coverage of our tests.
…orkflow configuration

chore(test.yml): remove commented out sections related to database preparation and integration testing as they are not currently needed
chore(test.yml): rename the 'build' job to 'build-test' for clarity
chore(test.yml): add 'dependabot' job to handle automatic merging of dependabot pull requests
feat(test.yml): add build and package job to build and package the project
feat(test.yml): add unit test job to run Java tests on different JDK versions
feat(test.yml): add sonar-pr job to analyze pull requests with SonarQube
The dependabot workflow was removed as it is no longer needed for the project.
…ration tests

Integration tests are being skipped by adding the maven-failsafe-plugin configuration with the skipITs property set to true. This is done to speed up the build process and avoid running unnecessary tests during development.
… integration tests

The maven-failsafe-plugin configuration in the pom.xml file has been updated to include the execution of integration tests. The skipITs property has been replaced with includes property, which specifies the patterns for the integration test files to be executed. This change allows the integration tests with filenames starting with "IT" or ending with "IT" to be included in the test execution.
…ed after the next liquibase parent pom release
…T-16000 for compatibility and consistency with other workflows
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

chore(workflows): remove snyk-nightly.yml workflow as it is no longer needed
chore(workflows): update sonar-pull-request.yml workflow to v0.4.9
.github/dependabot copy.yml Outdated Show resolved Hide resolved
The dependabot configuration file was removed as it is no longer needed for managing dependencies and automated updates.
@@ -185,27 +174,4 @@ jobs:
# uses: actions/upload-artifact@v3
# with:
# name: redshift-test-results
# path: build/spock-reports

dependabot:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependabot merge part... was it moved elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing :) It should need "unit-test" , not build - so it will only merge if tests are passing .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…t-test' to correctly specify the dependency
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jandroav jandroav merged commit 960697c into main Oct 16, 2023
8 of 9 checks passed
@jandroav jandroav deleted the DAT-16000 branch October 16, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants