Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync main branch to develop branch (#692) #694

Merged
merged 39 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
a3f66e4
Updated tinyint(1) to tinyint on expectedSql files to adress change m…
MalloD12 Oct 26, 2023
2967af8
Merge branch 'develop' into fix-issue-5069
KushnirykOleh Dec 5, 2023
b84fb9f
chore(main.yml): update Java version to 17 for better compatibility a…
Dec 11, 2023
fb00008
testing changes
Dec 11, 2023
2518c34
update sdk-maven
Dec 11, 2023
04e5f08
sync main branch to develop branch (#692)
sayaliM0412 Dec 12, 2023
bd18250
Merge branch 'develop' into fix-issue-5069
sayaliM0412 Dec 12, 2023
62a8af5
fixing conflicts
Dec 13, 2023
fb3914a
fix(main.yml): fix command syntax for installing liquibase snapshot
Dec 13, 2023
20ffeb8
fix(main.yml): fix command syntax by adding quotes around the argumen…
Dec 13, 2023
422019c
chore(pom.xml): add configuration for Liquibase plugin to support mul…
Dec 13, 2023
4e67ad6
chore(main.yml): add installation of Liquibase SDK snapshot to the bu…
Dec 13, 2023
c34b291
chore(main.yml): refactor Maven commands to improve readability and r…
Dec 13, 2023
dbe3452
chore(main.yml): comment out unnecessary lines to improve readability…
Dec 13, 2023
88e444d
chore(main.yml): update liquibase.sdk.branchSearch to include develop…
Dec 13, 2023
b38a553
chore(pom.xml): downgrade liquibase-sdk-maven-plugin version from 0.1…
Dec 13, 2023
b037f1d
chore(pom.xml): update liquibase-sdk-maven-plugin version from 0.10.2…
Dec 13, 2023
6c0d222
chore(pom.xml): remove unnecessary repo configuration in liquibase pl…
Dec 13, 2023
3575a2c
chore(main.yml): uncomment buildOverview commands to display build in…
Dec 13, 2023
28dc20a
chore(main.yml): remove unnecessary mvn liquibase-sdk:install-snapsho…
Dec 13, 2023
06e9a64
fix(main.yml): add mvn liquibase-sdk:install-snapshot command to inst…
Dec 13, 2023
2a606a3
Merge branch 'develop' into DAT-16387
sayaliM0412 Dec 14, 2023
83e8d16
use java version 17 and set GPM enabled =true
Dec 14, 2023
2cf02a1
chore(pom.xml): add liquibaseHome and allowInstall configuration to t…
Dec 14, 2023
85df63d
chore(main.yml): remove unnecessary empty line in the workflow file
Dec 14, 2023
a777cab
comment liquibase version
Dec 14, 2023
06140a3
comment liquibase version
Dec 14, 2023
7a57e7d
chore(main.yml): add steps to set liquibase-core version to 0-SNAPSHO…
Dec 14, 2023
9b08496
chore(main.yml): remove commented out code and add missing step to ch…
Dec 14, 2023
ef38177
changing release attribute back to false
Dec 14, 2023
704a858
Merge pull request #641 from liquibase/fix-issue-5069
PavloTytarchuk Dec 14, 2023
c20ef77
Merge branch 'develop' into DAT-16387
sayaliM0412 Dec 14, 2023
7f9cb12
DAT-16387- re-add the deleted code (#696)
sayaliM0412 Dec 14, 2023
18bc299
fixed tests for in the develop branch
PavloTytarchuk Dec 14, 2023
720d77e
fixed tests for in the develop branch 2
PavloTytarchuk Dec 14, 2023
d331577
fixed percona tests for in the develop branch
PavloTytarchuk Dec 14, 2023
fdb84ea
Update attributes from liquibase sdk-maven-plugin (#698)
sayaliM0412 Dec 14, 2023
6a4cb1e
Merge pull request #697 from liquibase/fix_develop_failures
PavloTytarchuk Dec 14, 2023
143d26e
Merge branch 'main' into develop
sayaliM0412 Dec 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ jobs:
}
}


- name: maven-settings-xml-action
uses: whelk-io/maven-settings-xml-action@v21
with:
Expand All @@ -197,7 +198,7 @@ jobs:
"id": "liquibase",
"url": "https://maven.pkg.github.com/liquibase/liquibase",
"releases": {
"enabled": "false"
"enabled": "true"
},
"snapshots": {
"enabled": "true",
Expand All @@ -208,7 +209,7 @@ jobs:
"id": "liquibase-pro",
"url": "https://maven.pkg.github.com/liquibase/liquibase-pro",
"releases": {
"enabled": "false"
"enabled": "true"
},
"snapshots": {
"enabled": "true",
Expand All @@ -230,6 +231,12 @@ jobs:
}
]

- uses: actions/setup-java@v3
with:
java-version: '17'
distribution: 'temurin'
cache: 'maven'

- name: Install Snapshot Liquibase
if: steps.configure-build.outputs.useLiquibaseSnapshot == 'true'
env:
Expand All @@ -241,6 +248,14 @@ jobs:
"-Dliquibase.sdk.repo=liquibase/liquibase,liquibase/liquibase-pro" \
"-Dliquibase.sdk.proWorkflowId=build.yml"\
"-Dliquibase.sdk.workflowId=run-tests.yml"

mvn -B versions:set-property -Dproperty=liquibase-core.version -DnewVersion=0-SNAPSHOT
mvn liquibase-sdk:install-snapshot-cli \
"-Dliquibase.sdk.branchSearch=${{ steps.configure-build.outputs.liquibaseBranch }},master,main,develop" \
"-Dliquibase.sdk.repo=liquibase/liquibase,liquibase/liquibase-pro" \
"-Dliquibase.sdk.proWorkflowId=build.yml" \
"-Dliquibase.sdk.workflowId=run-tests.yml"


chmod -R 777 bin
ls -l ./bin
Expand Down Expand Up @@ -279,7 +294,7 @@ jobs:

- uses: actions/setup-java@v4
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
cache: 'maven'

Expand Down
2 changes: 2 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@
<version>0.10.23</version>
<configuration>
<githubToken>${env.GITHUB_TOKEN}</githubToken>
<liquibaseHome>bin</liquibaseHome>
<allowInstall>true</allowInstall>
</configuration>
</plugin>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
"liquibase.structure.core.Column": [
{
"column": {
"defaultValue": "1\\!\\{liquibase.statement.DatabaseFunction\\}",
"defaultValue": "1\\!\\{java.lang.Integer\\}",
"name": "booleanColumn",
"nullable": true,
"type": {
"typeName": "BOOLEAN"
"typeName": "TINYINT"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"name": "boolean_col",
"nullable": false,
"type": {
"typeName": "BOOLEAN"
"typeName": "TINYINT"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": "booleanColumn",
"nullable": true,
"type": {
"typeName": "BIT"
"typeName": "TINYINT"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"name": "boolean_col",
"nullable": false,
"type": {
"typeName": "BIT"
"typeName": "TINYINT"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@
"column": {
"name": "bool",
"type": {
"typeName": "BIT"
"typeName": "TINYINT"
}
}
},
{
"column": {
"name": "boolean",
"type": {
"typeName": "BIT"
"typeName": "TINYINT"
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": "booleanColumn",
"nullable": true,
"type": {
"typeName": "BIT"
"typeName": "TINYINT"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,173 @@
{
"snapshot": {
"objects": {
"liquibase.structure.core.Table": [
{
"table": {
"name": "datatypes.numeric_test_table"
}
}
],
"liquibase.structure.core.Column": [
{
"column": {
"name": "bit",
"type": {
"typeName": "BIT"
}
}
},
{
"column": {
"name": "bit1",
"type": {
"columnSize": "1\\!\\{java.lang.Integer\\}",
"typeName": "BIT"
}
}
},
{
"column": {
"name": "bit64",
"type": {
"columnSize": "64\\!\\{java.lang.Integer\\}",
"typeName": "BIT"
}
}
},
{
"column": {
"name": "tinyint",
"type": {
"typeName": "TINYINT"
}
}
},
{
"column": {
"name": "tinyint.unsigned",
"type": {
"typeName": "TINYINT UNSIGNED"
}
}
},
{
"column": {
"name": "bool",
"type": {
"typeName": "TINYINT"
}
}
},
{
"column": {
"name": "boolean",
"type": {
"typeName": "TINYINT"
}
}
},
{
"column": {
"name": "smallint",
"type": {
"typeName": "SMALLINT"
}
}
},
{
"column": {
"name": "smallint.unsigned",
"type": {
"typeName": "SMALLINT UNSIGNED"
}
}
},
{
"column": {
"name": "mediumint",
"type": {
"typeName": "MEDIUMINT"
}
}
},
{
"column": {
"name": "mediumint.unsigned",
"type": {
"typeName": "MEDIUMINT UNSIGNED"
}
}
},
{
"column": {
"name": "int",
"type": {
"typeName": "INT"
}
}
},
{
"column": {
"name": "int.unsigned",
"type": {
"typeName": "INT UNSIGNED"
}
}
},
{
"column": {
"name": "bigint",
"type": {
"typeName": "BIGINT"
}
}
},
{
"column": {
"name": "bigint.unsigned",
"type": {
"typeName": "BIGINT UNSIGNED"
}
}
},
{
"column": {
"name": "decimal",
"type": {
"typeName": "DECIMAL"
}
}
},
{
"column": {
"name": "decimal.max",
"type": {
"columnSize": "65\\!\\{java.lang.Integer\\}",
"decimalDigits": "30\\!\\{java.lang.Integer\\}",
"typeName": "DECIMAL"
}
}
},
{
"column": {
"name": "float",
"type": {
"typeName": "FLOAT"
}
}
},
{
"column": {
"name": "float.10.10",
"type": {
"columnSize": "10\\!\\{java.lang.Integer\\}",
"decimalDigits": "10\\!\\{java.lang.Integer\\}",
"typeName": "FLOAT"
}
}
}
]
}
}
}
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ALTER TABLE lbcat.authors ADD booleanColumn TINYINT(1) NULL
ALTER TABLE lbcat.authors ADD booleanColumn TINYINT NULL
ALTER TABLE lbcat.authors ALTER booleanColumn SET DEFAULT 1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CREATE TABLE lbcat.test_table (id INT NULL, bit_col BIT(1) NULL, boolean_col TINYINT(1) NULL)
CREATE TABLE lbcat.test_table (id INT NULL, bit_col BIT(1) NULL, boolean_col TINYINT NULL)
INSERT INTO lbcat.test_table (id) VALUES (1)
UPDATE lbcat.test_table SET bit_col = 1 WHERE bit_col IS NULL
ALTER TABLE lbcat.test_table MODIFY bit_col BIT(1) NOT NULL
UPDATE lbcat.test_table SET boolean_col = 1 WHERE boolean_col IS NULL
ALTER TABLE lbcat.test_table MODIFY boolean_col TINYINT(1) NOT NULL
ALTER TABLE lbcat.test_table MODIFY boolean_col TINYINT NOT NULL
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ALTER TABLE lbcat.authors ADD booleanColumn TINYINT(1) NULL
ALTER TABLE lbcat.authors ADD booleanColumn TINYINT NULL
ALTER TABLE lbcat.authors ALTER booleanColumn SET DEFAULT 1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CREATE TABLE lbcat.test_table (id INT NULL, bit_col BIT(1) NULL, boolean_col TINYINT(1) NULL)
CREATE TABLE lbcat.test_table (id INT NULL, bit_col BIT(1) NULL, boolean_col TINYINT NULL)
INSERT INTO lbcat.test_table (id) VALUES (1)
UPDATE lbcat.test_table SET bit_col = 1 WHERE bit_col IS NULL
ALTER TABLE lbcat.test_table MODIFY bit_col BIT(1) NOT NULL
UPDATE lbcat.test_table SET boolean_col = 1 WHERE boolean_col IS NULL
ALTER TABLE lbcat.test_table MODIFY boolean_col TINYINT(1) NOT NULL
ALTER TABLE lbcat.test_table MODIFY boolean_col TINYINT NOT NULL
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CREATE TABLE lbcat.`datatypes.numeric_test_table` (bit BIT NULL, bit1 BIT(1) NULL, bit64 BIT(64) NULL, `tinyint` TINYINT NULL, `tinyint.unsigned` TINYINT unsigned NULL, bool TINYINT(1) NULL, boolean TINYINT(1) NULL, `smallint` SMALLINT NULL, `smallint.unsigned` SMALLINT unsigned NULL, `mediumint` MEDIUMINT NULL, `mediumint.unsigned` MEDIUMINT unsigned NULL, `int` INT NULL, `int.unsigned` INT unsigned NULL, `bigint` BIGINT NULL, `bigint.unsigned` BIGINT unsigned NULL, `decimal` DECIMAL NULL, `decimal.max` DECIMAL(65, 30) NULL, `float` FLOAT NULL, `float.10.10` FLOAT(10, 10) NULL, double_precision_column DOUBLE PRECISION(5, 2) NULL, precision_column DOUBLE(5, 2) NULL)
CREATE TABLE lbcat.`datatypes.numeric_test_table` (bit BIT NULL, bit1 BIT(1) NULL, bit64 BIT(64) NULL, `tinyint` TINYINT NULL, `tinyint.unsigned` TINYINT unsigned NULL, bool TINYINT NULL, boolean TINYINT NULL, `smallint` SMALLINT NULL, `smallint.unsigned` SMALLINT unsigned NULL, `mediumint` MEDIUMINT NULL, `mediumint.unsigned` MEDIUMINT unsigned NULL, `int` INT NULL, `int.unsigned` INT unsigned NULL, `bigint` BIGINT NULL, `bigint.unsigned` BIGINT unsigned NULL, `decimal` DECIMAL NULL, `decimal.max` DECIMAL(65, 30) NULL, `float` FLOAT NULL, `float.10.10` FLOAT(10, 10) NULL, double_precision_column DOUBLE PRECISION(5, 2) NULL, precision_column DOUBLE(5, 2) NULL)
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ALTER TABLE lbcat.authors ADD booleanColumn TINYINT(1) NULL
ALTER TABLE lbcat.authors ADD booleanColumn TINYINT NULL
ALTER TABLE lbcat.authors ALTER booleanColumn SET DEFAULT 1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CREATE TABLE lbcat.`datatypes.numeric_test_table` (bit BIT NULL, bit1 BIT(1) NULL, bit64 BIT(64) NULL, `tinyint` TINYINT NULL, `tinyint.unsigned` TINYINT unsigned NULL, bool TINYINT(1) NULL, boolean TINYINT(1) NULL, `smallint` SMALLINT NULL, `smallint.unsigned` SMALLINT unsigned NULL, `mediumint` MEDIUMINT NULL, `mediumint.unsigned` MEDIUMINT unsigned NULL, `int` INT NULL, `int.unsigned` INT unsigned NULL, `bigint` BIGINT NULL, `bigint.unsigned` BIGINT unsigned NULL, `decimal` DECIMAL NULL, `decimal.max` DECIMAL(65, 30) NULL, `float` FLOAT NULL, `float.10.10` FLOAT(10, 10) NULL)
CREATE TABLE lbcat.`datatypes.numeric_test_table` (bit BIT NULL, bit1 BIT(1) NULL, bit64 BIT(64) NULL, `tinyint` TINYINT NULL, `tinyint.unsigned` TINYINT unsigned NULL, bool TINYINT NULL, boolean TINYINT NULL, `smallint` SMALLINT NULL, `smallint.unsigned` SMALLINT unsigned NULL, `mediumint` MEDIUMINT NULL, `mediumint.unsigned` MEDIUMINT unsigned NULL, `int` INT NULL, `int.unsigned` INT unsigned NULL, `bigint` BIGINT NULL, `bigint.unsigned` BIGINT unsigned NULL, `decimal` DECIMAL NULL, `decimal.max` DECIMAL(65, 30) NULL, `float` FLOAT NULL, `float.10.10` FLOAT(10, 10) NULL)
Loading