This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Defer users and channels creation #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me as long as the tests get updated. |
|
Ouch, totally slipped my mind. |
|
@jimmycuadra tests fixed! |
|
Looks like one is still failing. >_< |
|
Damn that's a race condition :/. Maybe it's best to forget this. I can monkey patch it from my end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a bit weird I admit, but our Slack team have over 1200 users and 1000 channels. So the insertion on boot actually takes 2 good seconds. Which mean 2 additional seconds of downtime on every deploy.
@jimmycuadra @pallan @sirupsen for review please.