This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Added Slack profile back into metadata #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hmset issue in litaio#57. The hmset method expects an even length Array. Any empty array in the metadata hash will be ejected when it's flattened and will result in an uneven Array.
|
Sorry for the delay in responding — can you add a test case that verifies this behavior? |
|
Sorry my delay! I will attempt to add a test when I find some time. |
maxvt
pushed a commit
to maxvt/lita-slack
that referenced
this pull request
Oct 30, 2016
This builds on litaio#80 which has not received a response by the original committer.
maxvt
pushed a commit
to maxvt/lita-slack
that referenced
this pull request
Oct 30, 2016
This builds on litaio#80 which has not received a response by the original committer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hmset issue in #57. The hmset method expects an even length Array. Any empty array in the metadata hash will be ejected when it's flattened.