Fix bugs in hwp_sys default mueller parameters definition #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj-gomes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #335.
I also changed the multiple "if not hasattr(self, attr):" to "if not paramdict.get(attr):" because, when assigning the value "False" to a non-given parameter, the hasattr will consider the parameter already exists (is equal to False) and return True.
This is only a problem when the argument "mueller_or_jones" == "mueller". It must be because the parameters h1,h2,z1,z2,beta in the ideal case are all zeros and as False = 0, it works.