24.0.1 - Pre-MWEB #900
Open
24.0.1 - Pre-MWEB #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPG keys for coblee, shaolinfry, thrasher, xinxi, and davidburkett38
…tment period when retargeting
…x20000000) for all blocks
…MENT, and STALE_CHECK_INTERVAL
losh11
reviewed
May 30, 2023
| base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,0); | ||
| vSeeds.emplace_back("seed-a.litecoin.loshan.co.uk"); | ||
| vSeeds.emplace_back("dnsseed.thrasher.io"); | ||
| vSeeds.emplace_back("dnsseed.litecointools.com"); |
There was a problem hiding this comment.
litecointools is a dead dns seeder. please remove.
losh11
reviewed
May 30, 2023
| vSeeds.emplace_back("dnsseed.thrasher.io"); | ||
| vSeeds.emplace_back("dnsseed.litecointools.com"); | ||
| vSeeds.emplace_back("dnsseed.litecoinpool.org"); | ||
| vSeeds.emplace_back("dnsseed.koin-project.com"); |
losh11
reviewed
May 30, 2023
| @@ -183,68 +175,62 @@ class CTestNetParams : public CChainParams { | |||
| public: | |||
There was a problem hiding this comment.
Comment above is a regression from v0.21, this is testnet4.
losh11
reviewed
May 30, 2023
| vSeeds.emplace_back("seed.tbtc.petertodd.org."); | ||
| vSeeds.emplace_back("seed.testnet.bitcoin.sprovoost.nl."); | ||
| vSeeds.emplace_back("testnet-seed.bluematt.me."); // Just a static list of stable node(s), only supports x9 | ||
| vSeeds.emplace_back("testnet-seed.litecointools.com"); |
|
File bitcoin-util-test.json needs to be renamed Running test/util/test_runner.py...
/usr/local/bin/python3.9 ../test/util/test_runner.py
Traceback (most recent call last):
File "/Users/loshan/Repos/litecoin/src/../test/util/test_runner.py", line 178, in <module>
main()
File "/Users/loshan/Repos/litecoin/src/../test/util/test_runner.py", line 42, in main
bctester(os.path.join(env_conf["SRCDIR"], "test", "util", "data"), "litecoin-util-test.json", env_conf)
File "/Users/loshan/Repos/litecoin/src/../test/util/test_runner.py", line 47, in bctester
with open(input_filename, encoding="utf8") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/loshan/Repos/litecoin/test/util/data/litecoin-util-test.json'
make[3]: *** [check-local] Error 1
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1 |
|
v24 removed gitian-building, replacing it with guix. Currently attemping a guix build fails as build, as openssl in not included as a dep in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging pre-MWEB Litecoin changes onto bitcoin core 24.0.1