Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(luna): improved the call object and implement the todos #215

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

mostafakamar2308
Copy link
Member

visual changes

  1. changed the animation of the videobar to use opacities rather than scaling
  2. changed the internet indicator to be a generic alert indicator and added a story for it
  3. Unfocused streams are now movable, and added MovableMedia component to luna to use it when needed

MISC changes

  1. removed unnecessary exports from the code

Logic Changes

  1. The call now accepts an array of streams and handles organization by itself

@mostafakamar2308 mostafakamar2308 self-assigned this Dec 16, 2024
@mostafakamar2308 mostafakamar2308 force-pushed the mk/call-pt2 branch 2 times, most recently from 6f3acda to bed54b1 Compare December 16, 2024 16:35
@neuodev
Copy link
Member

neuodev commented Dec 16, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 22, 2024

@mostafakamar2308 please rebase this branch on top of the latest master.

@@ -48,7 +39,7 @@ type Props = {
};
leaveCall: Void;
chatPanel?: React.ReactNode;
internetProblem?: boolean;
alert?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice name!

@neuodev
Copy link
Member

neuodev commented Dec 23, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 23, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev neuodev merged commit 4d53221 into master Dec 23, 2024
2 checks passed
@neuodev neuodev deleted the mk/call-pt2 branch December 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants