feat(nova): implemented tutor ratings #224

mostafakamar2308 · 2024-12-17T16:15:41Z

No description provided.

neuodev · 2024-12-17T16:20:02Z

neuodev · 2024-12-17T16:23:23Z

neuodev · 2024-12-17T20:32:12Z

apps/nova/src/components/TutorProfile/LoadingTutorInfo.tsx

+  const intl = useFormatMessage();
+  return (
+    <div className="h-full flex flex-col justify-center items-center gap-10 mt-20">
+      <div className="w-[80px] h-[80px] animate-spin flex items-center relative rounded-full justify-center bg-[conic-gradient(from_180deg_at_50%_50%,#1D7C4E_0deg,rgba(17,173,207,0)_360deg)]">


Why do we have to do it this way?

When I tried to copy as svg it wasn't being copied correctly, and I tried multiple times
So, I thought it won't be hard to recreate it using HTML

The spinner should be resuable. Please move it to luna and add storybooks.

One last thing, the spinning direction not correct.

This was a new style of loading so I thought it was a one off thing.
When I saw it reused in the dashboard, I made it reusable in luna
But I've done it again with the error here.

neuodev · 2024-12-17T20:33:34Z

apps/nova/src/components/TutorProfile/Ratings.tsx

+      <Typography
+        element="h4"
+        weight="bold"
+        className="text-natural-950 text-center mb-20"


It works I know but this is not the right place to put mb-20. I will let you decide where to put it.

neuodev · 2024-12-17T20:35:13Z

apps/nova/src/components/TutorProfile/Ratings.tsx

-  if (query.isLoading) return <Loading className="h-60" />;
-  if (query.isError) return <h1>Error</h1>;
-  if (!query.data) return null;
+  const ratings = ratingOrganizer(ratingsQuery.data.list, user.id);


For function names, it is better to use verbs. In this case it is better to name it orgainzeRatings or groupRatings.

neuodev · 2024-12-17T20:35:59Z

apps/nova/src/components/TutorProfile/Ratings.tsx

+        <Typography
+          element="subtitle-1"
+          weight="medium"
+          className="text-natural-950 w-2/3 text-center"


Why do we have to assing w-2/3?

wanted to have the sentence on 2 lines

I will find better way. I think it's better to have it on 2 lines and not let it stretch to be easier to read

I divided the text in ar-eg. I think this is a more elegant solution

It should be one sentence

neuodev · 2024-12-17T20:36:54Z

apps/nova/src/components/TutorProfile/TutorTabs.tsx

@@ -7,6 +7,7 @@ import { LocalId } from "@litespace/luna/locales";
 import cn from "classnames";
 import { AnimatePresence, motion } from "framer-motion";
 import ProfileInfo from "./ProfileInfo";
+import Ratings from "./Ratings";


Remember to always use absolute paths. You can always spot this by maing a self-review once you opend the pull request.

neuodev · 2024-12-17T20:37:34Z

apps/nova/src/components/TutorProfile/TutorTabs.tsx

@@ -114,7 +115,7 @@ export const TutorTabs: React.FC<{
            {tab === "ratings" ? (
              <Animate key="ratings" tab="ratings">
                <div className="min-h-96">


Remove this wrapping div. It was just for testing purposes.

neuodev · 2024-12-17T20:38:43Z

apps/nova/src/lib/ratings.ts

+    ratings: Array<{
+      name: string | null;
+
+      userId: number;
+
+      imageUrl: string | null;
+    }>;
+    value: number;


This type is the same as the TutorRatingCardGroup props. Please use this type and don't ceate a new one.

neuodev · 2024-12-17T21:36:27Z

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

neuodev · 2024-12-17T22:14:33Z

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

neuodev · 2024-12-19T09:15:10Z

@mostafakamar2308 please resolve the conflicts.

neuodev · 2024-12-19T11:28:09Z

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

mostafakamar2308 · 2024-12-19T11:39:36Z

@neuodev Done 🚀

packages/assets/package.json

packages/headless/src/rating.ts

packages/luna/src/locales/ar-eg.json

apps/nova/src/components/TutorProfile/Ratings.tsx

neuodev · 2024-12-20T05:09:22Z

apps/nova/src/components/TutorProfile/LoadingTutorInfo.tsx

+  const intl = useFormatMessage();
+  return (
+    <div className="h-full flex flex-col justify-center items-center gap-10 mt-20">
+      <div className="w-[80px] h-[80px] animate-spin flex items-center relative rounded-full justify-center bg-[conic-gradient(from_180deg_at_50%_50%,#1D7C4E_0deg,rgba(17,173,207,0)_360deg)]">


The spinner should be resuable. Please move it to luna and add storybooks.

One last thing, the spinning direction not correct.

neuodev · 2024-12-20T05:14:22Z

apps/nova/src/components/TutorProfile/Ratings.tsx

+        <Typography
+          element="subtitle-1"
+          weight="medium"
+          className="text-natural-950 w-2/3 text-center"


It should be one sentence

apps/nova/src/components/TutorProfile/Ratings.tsx

neuodev · 2024-12-20T05:16:49Z

apps/nova/src/lib/ratings.ts

+    if (rating.userId === currentUserId) {
+      currentUserRating = rating;
+      return;
+    }


I am not quite sure that this logic will work. When you return the logic below it will never be executed.

If you want to find the current user rating, you can find it independently.

const userRating = ratings.find(rating => rating.userId === currentUserId) || null;

neuodev · 2024-12-20T05:55:35Z

apps/nova/src/lib/ratings.ts

+  const ratingsWithFeedback: IRating.RateeRatings[] = [];
+  const ratingsWithoutFeedback: Omit<TutorRatingCardGroupProps, "tutorName">[] =
+    [];


I think we can do better. Based on the fact that the ratings returned by the backend will be ordered, we can rewrite the logic like this.

const organizedRatings: Array<{ type: 'owner', rating: IRating.RateeRatings, // note: that their is a typo in "RateeRatings". It should be just "RateeRating". }| { type: 'group', ratings: IRating.RateeRatings[]; // note: you don't need to use `TutorRatingCardGroupProps` because incase the group has only one member it should be rendered in `TutorRAtingCard` and not `TutorRatingCardGroup`. The `Rating` component will decide this. It is not the role of this function to decide. } | { type: 'with-feedback', rating: IRating.RateeRatings, }> = [] let buffer: IRating.RateeRatings[] = []; ratings.reduce((prev, curr) => { if (curr.userId === currentUserId) orgainizedRatings.push({type: 'owner', rating: curr}); if (!prev) return curr; // if the current rating is the same as the previous one it should go the buffer. if (prev && prev.value === curr.value && !curr.feedback) buffer.push(curr); // prev !== curr => end the previous group, and clear the buffer if (prev && ((prev.value !== curr.value) || (prev.value == curr.value && !!curr.feedback))) { const firstRating = first(buffer) const length = buffer.length; if (length === 1 && firstRatings && firstRating.feedback) organizedRatings.push({type: 'with-feedback', rating: firstRating}); if (length > 1) organizedRatings.push({type: 'group', ratings: buffer}); buffer = [curr] // new group } return curr }, null)

apps/nova/src/components/TutorProfile/TutorLoadingError.tsx

neuodev · 2024-12-20T06:28:37Z

@mostafakamar2308 please implement these (1, 2) designs instead.

neuodev · 2024-12-20T07:24:14Z

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

neuodev · 2024-12-20T13:48:23Z

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

neuodev · 2024-12-22T14:09:45Z

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

neuodev · 2024-12-22T16:15:35Z

apps/nova/src/lib/ratings.ts

+import { IRating } from "@litespace/types";
+import { TutorRatingCardGroupProps } from "@litespace/luna/TutorFeedback";
+
+export const organizeRatings = (


The implementation doesn't match this.

mostafakamar2308 requested a review from neuodev December 17, 2024 16:15

mostafakamar2308 self-assigned this Dec 17, 2024

mostafakamar2308 force-pushed the mk/tutor-rating branch from a77b762 to e29c929 Compare December 17, 2024 16:19

neuodev requested changes Dec 17, 2024

View reviewed changes

mostafakamar2308 force-pushed the mk/tutor-rating branch from e7be70d to cdcf7a6 Compare December 17, 2024 22:10

mostafakamar2308 requested a review from neuodev December 18, 2024 11:45

mostafakamar2308 force-pushed the mk/tutor-rating branch from cdcf7a6 to 174c92f Compare December 19, 2024 11:23

neuodev reviewed Dec 20, 2024

View reviewed changes

mostafakamar2308 marked this pull request as draft December 20, 2024 06:19

neuodev requested changes Dec 20, 2024

View reviewed changes

mostafakamar2308 force-pushed the mk/tutor-rating branch from 174c92f to 123c201 Compare December 20, 2024 07:19

mostafakamar2308 force-pushed the mk/tutor-rating branch from 123c201 to e2a7374 Compare December 20, 2024 13:43

mostafakamar2308 requested a review from neuodev December 20, 2024 13:44

mostafakamar2308 marked this pull request as ready for review December 20, 2024 13:44

mostafakamar2308 added 2 commits December 22, 2024 16:00

feat(nova): implemented tutor ratings

6572d3c

refactor(nova): improved ratings tabs implementation

6ac283a

mostafakamar2308 force-pushed the mk/tutor-rating branch from e2a7374 to 6ac283a Compare December 22, 2024 14:05

neuodev approved these changes Dec 22, 2024

View reviewed changes

neuodev merged commit 713b804 into master Dec 22, 2024
2 checks passed

neuodev deleted the mk/tutor-rating branch December 22, 2024 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nova): implemented tutor ratings #224

feat(nova): implemented tutor ratings #224

mostafakamar2308 commented Dec 17, 2024

neuodev commented Dec 17, 2024

neuodev commented Dec 17, 2024

neuodev Dec 17, 2024

mostafakamar2308 Dec 17, 2024

neuodev Dec 20, 2024

mostafakamar2308 Dec 20, 2024

neuodev Dec 17, 2024

neuodev Dec 17, 2024

neuodev Dec 17, 2024

mostafakamar2308 Dec 17, 2024 •

edited

Loading

mostafakamar2308 Dec 17, 2024

neuodev Dec 20, 2024

neuodev Dec 17, 2024

neuodev Dec 17, 2024

neuodev Dec 17, 2024

neuodev commented Dec 17, 2024

neuodev commented Dec 17, 2024

neuodev commented Dec 19, 2024

neuodev commented Dec 19, 2024

mostafakamar2308 commented Dec 19, 2024

neuodev Dec 20, 2024

neuodev Dec 20, 2024

neuodev Dec 20, 2024

neuodev Dec 20, 2024

neuodev commented Dec 20, 2024

neuodev commented Dec 20, 2024

neuodev commented Dec 20, 2024

neuodev commented Dec 22, 2024

neuodev Dec 22, 2024

feat(nova): implemented tutor ratings #224

feat(nova): implemented tutor ratings #224

Conversation

mostafakamar2308 commented Dec 17, 2024

neuodev commented Dec 17, 2024

neuodev commented Dec 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mostafakamar2308 Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neuodev commented Dec 17, 2024

neuodev commented Dec 17, 2024

neuodev commented Dec 19, 2024

neuodev commented Dec 19, 2024

mostafakamar2308 commented Dec 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neuodev commented Dec 20, 2024

neuodev commented Dec 20, 2024

neuodev commented Dec 20, 2024

neuodev commented Dec 22, 2024

Choose a reason for hiding this comment

mostafakamar2308 Dec 17, 2024 •

edited

Loading