Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: coverage unit tests for redis cache component. #242

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

mmoehabb
Copy link
Collaborator

No description provided.

@mmoehabb mmoehabb self-assigned this Dec 23, 2024
@mmoehabb mmoehabb force-pushed the moehab/cache-coverage-tests branch 3 times, most recently from 3812ffe to 9f2111f Compare December 23, 2024 15:53
packages/models/tests/cache/call.test.ts Outdated Show resolved Hide resolved
@mmoehabb mmoehabb force-pushed the moehab/cache-coverage-tests branch from 9f2111f to b0c4cda Compare December 23, 2024 16:11
@mmoehabb mmoehabb requested a review from neuodev December 23, 2024 16:50
@mmoehabb
Copy link
Collaborator Author

The pipeline before this change kept raising an error due to primary key violation. Local testing, on the other hand, raises no errors at all. I've worked around this tedious error by using a hard-coded values in the corresponding unit test; as shown in the commit.

@neuodev
Copy link
Member

neuodev commented Dec 24, 2024

The pipeline before this change kept raising an error due to primary key violation. Local testing, on the other hand, raises no errors at all. I've worked around this tedious error by using a hard-coded values in the corresponding unit test; as shown in the commit.

Sounds good 👌

@neuodev neuodev merged commit e49e5c6 into master Dec 24, 2024
2 checks passed
@neuodev neuodev deleted the moehab/cache-coverage-tests branch December 24, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants