Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: calls table and corresponding tables have been dropped; call is replaced with session_id. #245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: calls table and corresponding tables have been dropped; call is replaced with session_id. #245

wants to merge 2 commits into from
+669 −2,100

Conversation

mmoehabb
Copy link
Collaborator

No description provided.

@mmoehabb mmoehabb self-assigned this Dec 24, 2024
@mmoehabb mmoehabb force-pushed the moehab/session-id branch 3 times, most recently from 7e71288 to 272f364 Compare December 24, 2024 21:27
@neuodev
Copy link
Member

neuodev commented Dec 24, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 24, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 24, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@mmoehabb mmoehabb requested a review from neuodev December 24, 2024 21:49
neuodev
neuodev requested changes Dec 25, 2024
View reviewed changes
Copy link
Member

@neuodev neuodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left couple of comments. Please take a look.

packages/models/migrations/1716146586880_setup.js Outdated Show resolved Hide resolved
packages/models/src/interviews.ts Outdated Show resolved Hide resolved
packages/models/src/interviews.ts Show resolved Hide resolved
packages/models/src/lessons.ts Outdated Show resolved Hide resolved
packages/sol/src/session.ts Outdated Show resolved Hide resolved
services/server/src/handlers/interview.ts Outdated Show resolved Hide resolved
services/server/src/handlers/lesson.ts Outdated Show resolved Hide resolved
services/server/src/handlers/peer.ts Outdated Show resolved Hide resolved
services/server/src/handlers/session.ts Outdated Show resolved Hide resolved
services/server/src/middleware/accessControl.ts Outdated Show resolved Hide resolved
@mmoehabb mmoehabb requested a review from neuodev December 25, 2024 12:38
@neuodev
Copy link
Member

neuodev commented Dec 25, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

neuodev
neuodev requested changes Dec 26, 2024
View reviewed changes
services/server/tests/wss/call.test.ts Outdated Show resolved Hide resolved
services/server/src/wss/handlers/peer.ts Outdated Show resolved Hide resolved
services/server/src/wss/handlers/inputDevices.ts Outdated Show resolved Hide resolved
services/server/src/wss/handlers/inputDevices.ts Outdated Show resolved Hide resolved
services/server/src/wss/handlers/connection.ts Show resolved Hide resolved
packages/types/src/peer.ts Outdated Show resolved Hide resolved
packages/sol/src/session.ts Show resolved Hide resolved
packages/types/src/interview.ts Outdated Show resolved Hide resolved
packages/types/src/interview.ts Outdated Show resolved Hide resolved
packages/types/src/interview.ts Outdated Show resolved Hide resolved
@neuodev
Copy link
Member

neuodev commented Dec 26, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 26, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 26, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@neuodev
Copy link
Member

neuodev commented Dec 26, 2024

🚀 Nova
🚀 Luna
🚀 Nebula
🚀 Dashboard

@mmoehabb mmoehabb requested a review from neuodev December 26, 2024 17:43
neuodev
neuodev requested changes Dec 26, 2024
View reviewed changes
services/server/src/routes/chat.ts Show resolved Hide resolved
packages/models/src/interviews.ts Show resolved Hide resolved
packages/models/src/lessons.ts Outdated Show resolved Hide resolved
packages/atlas/src/chat.ts Outdated Show resolved Hide resolved
apps/nova/src/types/props.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuodev neuodev neuodev requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mmoehabb mmoehabb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoehabb @neuodev