feat(nova): impl tutor card v1 in tutors page #247
Merged
+223
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
moalidv
commented
Dec 25, 2024
•
moalidv
commented
moalidv
force-pushed
the
mo/nova-tutor-card-v1-integration
branch
from
51189ce to
f3395f4
Compare
moalidv
force-pushed
the
mo/nova-tutor-card-v1-integration
branch
from
f3395f4 to
5bdd48e
Compare
moalidv
commented
Dec 26, 2024
| @@ -573,6 +576,7 @@ | |||
| "labels.invoice.receipt.upload": "إرفاق الإيصال", | |||
| "labels.litespace": "لايت سبيس", | |||
| "labels.delete": "حذف", | |||
| "labels.coming-soon": "قريبا 🎉", | |||
There was a problem hiding this comment.
It seems that there are more than one feature that will come in the next versions so I think it will be better to leave this id in the labels instead writing it many times in different places.
neuodev
reviewed
Dec 26, 2024
| @@ -52,6 +75,7 @@ const Content: React.FC<{ | |||
| onBook={() => openBookingDialog(tutor)} | |||
| profileUrl={profileUrl} | |||
| imageUrl={tutor.image ? asFullAssetUrl(tutor.image) : null} | |||
| topics={topics} | |||
There was a problem hiding this comment.
Suggested change
| topics={topics} | |
| topics={tutor.topics} |
moalidv
force-pushed
the
mo/nova-tutor-card-v1-integration
branch
from
5bdd48e to
2f8ecde
Compare
neuodev
force-pushed
the
mo/nova-tutor-card-v1-integration
branch
from
2f8ecde to
ddd4fd2
Compare
neuodev
reviewed
Dec 26, 2024
|
|
||
| type Tutor = Element<ITutor.FindOnboardedTutorsApiResponse["list"]>; | ||
|
|
||
| const topics = [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.