ESI - Add Edit with Elementor #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add admin bar to "wp_body_open" Also make sure is loaded just once. Tested the fix for PHP 5 too
Tymotey
force-pushed
the
ESI-edit-with-elementor
branch
from
36a0ef1
to
5db36f2
Compare
hi-hai
reviewed
Jul 24, 2024
src/esi.cls.php
Outdated
| @@ -760,7 +763,12 @@ public function sub_widget_block($instance, $widget, $args) | |||
| public function sub_admin_bar_block() | |||
| { | |||
| global $wp_admin_bar; | |||
| static $rendered = false; | |||
There was a problem hiding this comment.
Don't define static here, plz define it in class level. Otherwise others won't be aware of this var and may cause conflict.
Tymotey
force-pushed
the
ESI-edit-with-elementor
branch
from
1bbf55b
to
acd608d
Compare
Tymotey
force-pushed
the
ESI-edit-with-elementor
branch
from
29d1647
to
cf4e313
Compare
hi-hai
reviewed
Jul 24, 2024
| @@ -771,6 +779,8 @@ public function sub_admin_bar_block() | |||
| ); | |||
|
|
|||
| echo $this->sub_esi_block('admin-bar', 'adminbar', $params); | |||
|
|
|||
| $this->admin_rendered = true; | |||
There was a problem hiding this comment.
This line is better moved to above line 781. That can give an additional safe check to avoid infinite embed just in case in $this->sub_esi_block() it called some hook which fall into this func again. How do you think?
hi-hai
pushed a commit
that referenced
this pull request
Jul 29, 2024
* ESI - Add Edit with Elementor Add admin bar to "wp_body_open" Also make sure is loaded just once. Tested the fix for PHP 5 too * Move rendered to class level * Review change --------- Co-authored-by: Timotei <[email protected]>
hi-hai
pushed a commit
that referenced
this pull request
Aug 6, 2024
* ESI - Add Edit with Elementor Add admin bar to "wp_body_open" Also make sure is loaded just once. Tested the fix for PHP 5 too * Move rendered to class level * Review change --------- Co-authored-by: Timotei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.