CI changes #742
CI changes #742
Conversation
…nd focus on rate improvement.
…2.0. * **Core** Minimum required WP version escalated to WP v5.3.
…uthentication and validation.
Co-authored-by: Timotei <[email protected]>
| "./vendor/bin/phpcs -p . --standard=./phpcs.xml.dist" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
There should be a newline at end of file.
There was a problem hiding this comment.
It get removed by Prettier. Should I add it manually?
|
I think this is not the GHA setup you want. |
|
Contribute now, before merge |
I have to inform you that I am struggling with
|
|
@szepeviktor For us current script is almost enought, we added Code Sniffer as a code check, no to correct or fix the code. |
Yes. All the above tools. e.g. #696 |
Add Code Sniffer actions
Tymotey
force-pushed
the
CI-add_code_sniff
branch
from
11de4ab
to
ad67220
Compare
|
Moved to #744 @szepeviktor thank you for the code and iddeeas |
|
@timotei-litespeed Without the above tools, or without a coding standard you are theoretically cut off from bug-free code. That is very sad to see.
You could have a custom coding standard!! |
|
I agree that withput a coding standard there is posibility for bugs to appear. For now this automation will help us make the code cleaner. Thank you for suggestions but for NOW the changes are enought for the time allocated for this change. 👍 |
Added PHP Code sniffer integration
For local:
Auto detectset to Checkedon savePrerequirement: Node 16, Composer, PHP 7.2
Install:
make sure there is a empty folder:
.cachein root of plugin folderopen terminal
run:
npm installrun:
composer installto run sniffer manually:
composer run sniff-check