Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix it + Lint changes #8

Merged
merged 5 commits into from
Oct 22, 2024
Merged

ci: Fix it + Lint changes #8

merged 5 commits into from
Oct 22, 2024

Conversation

Alc-Alc
Copy link
Contributor

@Alc-Alc Alc-Alc commented Oct 20, 2024 •
edited
Loading

  • Update CI actions to fix awesome-lint
  • Removed duplicate links.
  • Plugin links were the most duplicated ones, I reworded it to remove the discrepancy while still "emphasizing" the plugin enabled repos.
  • Reddit link 403s, idk why, we can ignore that?

@Alc-Alc Alc-Alc requested review from a team as code owners October 20, 2024 08:37
@Alc-Alc Alc-Alc force-pushed the fix-ci branch 7 times, most recently from 2d83afc to 939f367 Compare October 20, 2024 09:27
@Alc-Alc Alc-Alc requested a review from JacobCoffee October 20, 2024 09:35
ci(awesome-lint): Update Node.js to fix one of the job
05bddce 
ci: Push event only on main
style: Remove duplicates, fix broken links.
@Alc-Alc Alc-Alc changed the title ci(awesome-lint): Update Node.js ci: Fix it + Lint changes Oct 20, 2024
sobolevn
sobolevn approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Two optional suggestions.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
JacobCoffee
JacobCoffee reviewed Oct 21, 2024
View reviewed changes
README.md Show resolved Hide resolved
@JacobCoffee
Copy link
Member

probably need to set $ awesome_bot README.md --allow 403,429 or something to make reddit happy

@Alc-Alc
Copy link
Contributor Author

Alc-Alc commented Oct 21, 2024

probably need to set $ awesome_bot README.md --allow 403,429 or something to make reddit happy

I thought about this, we already allowed some status codes there but 403 felt like a legit code to not allow, but in this case its rather annoying, I can add 403 if you are ok though

@JacobCoffee
Copy link
Member

@Alc-Alc maybe awesome-bot allows scoping where the 403 is allowed from

@Alc-Alc Alc-Alc merged commit a78a6db into main Oct 22, 2024
2 checks passed
@Alc-Alc Alc-Alc deleted the fix-ci branch October 22, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@JacobCoffee JacobCoffee JacobCoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alc-Alc @JacobCoffee @sobolevn