Skip to content

Commit

Permalink
chore(infra): remove poetry in devcontainer.json (#3462)
Browse files Browse the repository at this point in the history
* infra: remove poetry

* chore: remove trailing commas
  • Loading branch information
Alc-Alc authored May 6, 2024
1 parent d5196ed commit 405738d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ FROM python:${VARIANT}
RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
&& apt-get purge -y fish

RUN python3 -m pip install --upgrade setuptools cython pip poetry
RUN python3 -m pip install --upgrade setuptools cython pip pdm
36 changes: 16 additions & 20 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,27 @@
"name": "litestar-org/litestar",
"build": {
"dockerfile": "./Dockerfile",
"context": ".",
"context": "."
},
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {
"installZsh": "true",
"username": "vscode",
"userUid": "1000",
"userGid": "1000",
"upgradePackages": "true",
"upgradePackages": "true"
},
"ghcr.io/devcontainers/features/github-cli:1": {},
"ghcr.io/devcontainers-contrib/features/pre-commit:2": {},
"ghcr.io/devcontainers/features/python:1": "none",
"ghcr.io/devcontainers/features/git:1": {
"version": "latest",
"ppa": "false",
},
"ppa": "false"
}
},
"customizations": {
"codespaces": {
"openFiles": ["CONTRIBUTING.rst"],
"openFiles": ["CONTRIBUTING.rst"]
},
"vscode": {
"extensions": [
Expand All @@ -31,7 +31,7 @@
"github.vscode-github-actions",
"ms-python.black-formatter",
"ms-python.mypy-type-checker",
"charliermarsh.ruff",
"charliermarsh.ruff"
],
"settings": {
"python.editor.defaultFormatter": "charliermarsh.ruff",
Expand All @@ -45,26 +45,22 @@
"terminal.integrated.profiles.linux": {
"bash": {
"path": "bash",
"icon": "terminal-bash",
"icon": "terminal-bash"
},
"zsh": {
"path": "zsh",
"path": "zsh"
},
"fish": {
"path": "fish",
},
},
},
},
"path": "fish"
}
}
}
}
},
"forwardPorts": [8000],
"postCreateCommand": [
"poetry",
"install",
"--extras",
"full",
"--with",
"docs,lint",
"pdm",
"install"
],
"remoteUser": "vscode",
"remoteUser": "vscode"
}

0 comments on commit 405738d

Please sign in to comment.