Skip to content

Commit

Permalink
Merge branch 'main' into plugins-docs-updates
Browse files Browse the repository at this point in the history
  • Loading branch information
JacobCoffee authored Mar 8, 2024
2 parents ddfcff2 + 1fb981d commit dd93fac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}

test-platform-compat:
if: github.event_name == 'push'
if: github.event_name == 'push' || contains(github.event.pull_request.labels.*.name, 'test platform compat')
strategy:
fail-fast: false
matrix:
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/test_stores.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,8 @@ async def test_file_store_handle_rename_fail(file_store: FileStore, mocker: Mock
assert Path(mock_unlink.call_args_list[0].args[0]).with_suffix("") == file_store.path.joinpath("foo")


async def test_redis_store_with_client_shutdown() -> None:
@pytest.mark.xdist_group("redis")
async def test_redis_store_with_client_shutdown(redis_service: None) -> None:
redis_store = RedisStore.with_client(url="redis://localhost:6397")
assert await redis_store._redis.ping()
# remove the private shutdown and the assert below fails
Expand Down

0 comments on commit dd93fac

Please sign in to comment.