fix(repositories): fix #2358 by re-exporting filters and exceptions from advanced-alchemy #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provinzkraut
commented
Sep 25, 2023
provinzkraut
force-pushed
the
fix-2358
branch
from
0dd5d74 to
98a8ef0
Compare
|
I think we should probably remove the imports in advanced-alchemy that try to import the filters from Litestar first. Otherwise we might run into a circular import here. |
|
@provinzkraut @v3ss0n I think this one may be ready for a final review. I've removed the exports from |
provinzkraut
commented
Sep 30, 2023
…rom advanced-alchemy Signed-off-by: Janek Nouvertné <[email protected]>
Signed-off-by: Janek Nouvertné <[email protected]>
Signed-off-by: Janek Nouvertné <[email protected]>
provinzkraut
force-pushed
the
fix-2358
branch
from
5d0c0b5 to
9c6112e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2360 |
cofin
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2358 by adding some missing re-exports from advanced-alchemy.