Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: additional CI and PDM cleanup #2413

Merged
merged 9 commits into from
Oct 7, 2023

Conversation

cofin
Copy link
Member

@cofin cofin commented Oct 7, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

This PR does a variety of PDM cleanup activities

  • Applies TOML linting to the pyproject.toml and validated against the PyProject specification
  • Removed unsupported group attribute and pinned dev install of exceptiongroup to <3.11
  • Removes pre-commit install from Makefile
  • add pdm install -G:all to PDM installation to grab optional dev dependencies
  • Remove PDM lock check from pre-commit. This has a similar issue as with poetry and leads to many failures due to hash conflicts
  • Adds README.md to codespell. The latest updates a raising errors for proper names
  • Adds httptools and uvloop to the standard group. These are both performance optionals for uvicorn that normal come with the standard package. websockets is the only standard dependency from uvicorn currently excluded.
  • Removes asyncmy, oracledb, spanner, and asyncmy from dependencies
  • Remove unused SQLAlchemy pytest markers
  • Remove docker fixture references to Oracle, MySQL, and Spanner

Close Issue(s)

@cofin cofin requested review from a team as code owners October 7, 2023 03:24
@cofin cofin changed the title chore: updated dev deps chore: additional CI and PDM cleanup Oct 7, 2023
@cofin cofin merged commit da2a0f2 into litestar-org:main Oct 7, 2023
14 checks passed
@cofin cofin deleted the pyproject-cleanup branch October 7, 2023 05:48
@cofin cofin linked an issue Oct 7, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infrastructure: replace poetry
2 participants