Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds a deprecation warning for litestar.contrib.piccolo #2704

Merged
merged 7 commits into from
Nov 22, 2023
Merged

feat: adds a deprecation warning for litestar.contrib.piccolo #2704

merged 7 commits into from
Nov 22, 2023

Conversation

cofin
Copy link
Member

@cofin cofin commented Nov 18, 2023 •
edited
Loading

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • This functionality has been moved to it's own plugin litestar-piccolo that includes all of the previous functionality and additional features.

Close Issue(s)

@cofin cofin requested review from a team as code owners November 18, 2023 21:15
@cofin cofin enabled auto-merge (squash) November 18, 2023 21:16
JacobCoffee
JacobCoffee approved these changes Nov 20, 2023
View reviewed changes
litestar/contrib/piccolo.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cofin cofin merged commit c68a549 into main Nov 22, 2023
14 checks passed
@cofin cofin deleted the litestar-piccolo-plugin branch November 22, 2023 02:23
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCoffee JacobCoffee JacobCoffee approved these changes

@peterschutt peterschutt Awaiting requested review from peterschutt

@provinzkraut provinzkraut Awaiting requested review from provinzkraut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cofin @JacobCoffee