Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix dangling coroutines in request extraction handling cleanup #3735

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

provinzkraut
Copy link
Member

Fix #3734.

Ensure all data extractors are properly awaited by removing the delayed await

@provinzkraut provinzkraut requested review from a team as code owners September 14, 2024 09:47
@github-actions github-actions bot added area/kwargs area/private-api This PR involves changes to the privatized API size: small type/bug pr/internal labels Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (053ef14) to head (f6da5e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3735      +/-   ##
==========================================
- Coverage   98.29%   98.29%   -0.01%     
==========================================
  Files         330      330              
  Lines       15123    15118       -5     
  Branches     2401     2399       -2     
==========================================
- Hits        14865    14860       -5     
  Misses        117      117              
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut enabled auto-merge (squash) September 14, 2024 09:53
@github-actions github-actions bot added the area/dependencies This PR involves changes to the dependencies label Sep 14, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies This PR involves changes to the dependencies area/kwargs area/private-api This PR involves changes to the privatized API pr/internal size: small type/bug
Projects
None yet
2 participants