fix(OpenAPI): Correctly handle msgspec.Struct tagged unions
#3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/private-api
provinzkraut
force-pushed
the
fix/3659-msgspec-tag-field-not-included-in-schema
branch
from
7324618 to
d95e79c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 331 331
Lines 15272 15277 +5
Branches 2444 2446 +2
=======================================
+ Hits 15020 15025 +5
Misses 112 112
Partials 140 140 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3742 |
cofin
approved these changes
Sep 15, 2024
provinzkraut
deleted the
fix/3659-msgspec-tag-field-not-included-in-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where we would not include the struct fields implicitly generated by msgspec for its tagged union support.
The change consists of an addition to the OpenAPI plugin where the tagged field will be added as a
constto the schema.Fix #3659.