fix(typing): Fix typing in websocket listener class #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dependencies
olzhasar
force-pushed
the
websockets-type-fix
branch
from
6ba7dbd to
8813706
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3765 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 339 339
Lines 15371 15371
Branches 1694 1694
=======================================
Hits 15128 15128
Misses 114 114
Partials 129 129 ☔ View full report in Codecov by Sentry. |
olzhasar
force-pushed
the
websockets-type-fix
branch
from
8813706 to
b14a90f
Compare
olzhasar
force-pushed
the
websockets-type-fix
branch
from
b14a90f to
4530c6e
Compare
|
Is there anything preventing this PR from being merged? |
cofin
approved these changes
Nov 17, 2024
cofin
force-pushed
the
websockets-type-fix
branch
from
4530c6e to
b206ca9
Compare
|
@all-contributors add @olzhasar for bugs and docs |
|
I've put up a pull request to add @olzhasar! 🎉 |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3763
It seems that declaring the actual method is the only way to comply with
mypyin such cases.There is a
ruffrule that forbids empty methods in abstract classes, had to disable that for the relevant module.Closes