-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move litestar.contrib.prometheus
to litestar.plugins.prometheus
#3863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3863 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 339 343 +4
Lines 15416 15456 +40
Branches 1702 1702
=======================================
+ Hits 15171 15211 +40
Misses 115 115
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
litestar.contrib.prometheus
litestar.contrib.prometheus
to litestar.plugins.prometheus
9284589
to
7c5662d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry maybe a dumb q - what is the benefit here of moving from contrib
to plugins
aside from renaming it?
also i feel like this one is a good candidate to move outside of the stdlib into its own package and then we can assign it as an extra
The goal is to get any non-essential core code into a plugin style structure. Right now, we have both Re: the move to an external library I also agree. In fact, I think most (maybe all) of the plugins can ultimately be treated that way. We can do that in steps though. |
7c5662d
to
66ac2b3
Compare
66ac2b3
to
bc826f9
Compare
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3863 |
Description
feat: deprecate
litestar.contrib.prometheus
in favor of the new location oflitestar.plugins.prometheus
Closes