Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove optional group for litestar-htmx #3870

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: remove optional group for litestar-htmx #3870

merged 2 commits into from
Nov 21, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented Nov 21, 2024

Description

This PR removes the optional htmx group for the project dependencies. HTMX is a built in feature and is not optional.

Closes

@cofin cofin requested review from a team as code owners November 21, 2024 17:00
@github-actions github-actions bot added area/dependencies This PR involves changes to the dependencies size: small type/feat pr/internal labels Nov 21, 2024
@cofin cofin enabled auto-merge (squash) November 21, 2024 17:13
@cofin cofin changed the title feat: remove optional group for litestar-htmx fix: remove optional group for litestar-htmx Nov 21, 2024
@cofin cofin merged commit bcd467a into main Nov 21, 2024
25 checks passed
@cofin cofin deleted the htmx-fix branch November 21, 2024 17:15
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3870

@charles-dyfis-net
Copy link
Contributor

Insofar as the impetus for raising this duplication was a bug encountered in poetry2nix (infinite recursion at evaluation time when Litestar 2.13.0 is in use) -- with this PR merged the bug still is reachable but has a much easier workaround: adding litestar-htmx as a direct dependency of the project also using litestar suffices to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies This PR involves changes to the dependencies pr/internal size: small type/feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants