-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Valkey as a native store #3892
feat: add Valkey as a native store #3892
Conversation
f1adeea
to
b9d9137
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3892 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 345 346 +1
Lines 15605 15660 +55
Branches 1725 1730 +5
=======================================
+ Hits 15348 15403 +55
Misses 122 122
Partials 135 135 ☔ View full report in Codecov by Sentry. |
b9d9137
to
8290eda
Compare
8bd4148
to
4375467
Compare
8e6dc21
to
fb37e94
Compare
I went through and basically replicated the existing Redis tests for Valkey. They're just new tests, though I'm open to a less-duplicative approach if anyone can point me in the right direction (I guess parametrise all the currently-redis-specific tests and then add checks for type to handle The only thing that came up is that Valkey uses I'm going to leave this as it is now pending any feedback. |
8b111e4
to
992d5bc
Compare
Adds support for Valkey as a store option, alternative to Redis.
Adds (very) basic testing for the Valkey store type.
Adds an autogenerated documentation page for the ValkeyStore itself. Additionally includes some notes on the existing `stores.rst` usage page indicating the equivalence of Valkey/Redis.
992d5bc
to
8c85612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think this is fine for the initial implementation. There is probably some larger restructuring we'll do on a few things for 3.0, and this may be part of it. However, i think it's better to get this implemented in smaller chunks.
@all-contributors add @ftsartek for docs, tests and code |
I've put up a pull request to add @ftsartek! 🎉 |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3892 |
Description
litestar[valkey]
which installsvalkey
withlibvalkey
as an optimisation layer.