feat(ci): implement psycopg client installation for macos and windows
#3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ci
cofin
changed the title
psycopg client installation for macos and windows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3932 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 347 347
Lines 15727 15727
Branches 1738 1738
=======================================
+ Hits 15466 15467 +1
+ Misses 126 124 -2
- Partials 135 136 +1 ☔ View full report in Codecov by Sentry. |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3932 |
provinzkraut
reviewed
Jan 8, 2025
Comment on lines
+41
to
+55
| # Linux Source | ||
| - name: Install Build Dependencies | ||
| run: sudo apt-get install build-essential libpq-dev python3-dev -y | ||
| if: startsWith(inputs.os, 'ubuntu') | ||
|
|
||
| # MacOS Source | ||
| - name: Install Build Dependencies | ||
| run: brew install libpq && brew link --force libpq | ||
| if: startsWith(inputs.os, 'macos') | ||
|
|
||
| # Windows Source | ||
| - name: Install Build Dependencies | ||
| uses: ikalnytskyi/action-setup-postgres@v7 | ||
| if: startsWith(inputs.os, 'windows') | ||
|
|
There was a problem hiding this comment.
Shouldn't we skip those if we're not on 3.13, since we don't need to build psycopg there?
There was a problem hiding this comment.
we are actually running the test on 3.13 in windows and macos now as well. It's using the pure python implementation. The only requirement for those are the libpq development libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this CI implements the necessary steps for installing psycopg in osx and windows
Closes