fix: Incorrect to_schema generation for dataclass using ResultConverter #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure that is the best way to fix the issue.
Description
The following code was not working and returned
SQLSpecError: `schema_type` should be a valid Dataclass, Pydantic model or Msgspec struct
I tried to replace the
is_dataclass
by the built inis_dataclass
fromdataclasses
, it correctly identify whether the passed argument is a dataclass type (if it's a class) or an instance of a dataclass. Where the method intyping
was working only when it was an instance of the class.There was a fail also right after when trying to cast the dictionary into the dataclass.