Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenOCD config file updates #514

Closed
wants to merge 2 commits into from
Closed

Conversation

josuah
Copy link
Contributor

@josuah josuah commented Aug 1, 2023

As discussed in #513 here are two commits adjusting the config:

  • 63adcb9 which fixes a bug when $_CHIPNAME is not defined:
    set _CHIPNAME ecp5 as the only change.

  • 95b6fa1 which convert the syntax to the supported format.

These kind of refactoring are not expected to break anything, but still has the risk of any refactoring.
Should I keep the second commit away until everything can be tested again?

@enjoy-digital
Copy link
Member

Thanks @josuah, we are still using an old version of OpenOCD (https://github.com/enjoy-digital/openocd) and we'll have to switch to upstream before merging (at least test it on my side and evaluate the changes required for some other projects). I'll try to do it in not too long, but probably not before the end of the month.

@josuah
Copy link
Contributor Author

josuah commented Aug 3, 2023

I am actually glad that this gets deferred as it means it costs not more than it helps.
I will be so very patient... :)

@josuah josuah marked this pull request as draft September 14, 2023 21:16
@josuah
Copy link
Contributor Author

josuah commented Sep 1, 2024

Big refactors are best done by the authors themselves, that way no pressure either direction :)

@josuah josuah closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants